fix(*): adapt to kubelet configz endpoint changes to support K8s 1.28 #691
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caohe
added
bug
caohe
requested review from
luomingmeng,
nightmeng,
xu282934741 and
waynepeking348
as code owners
Signed-off-by: caohe <caohe9603@gmail.com>
caohe
force-pushed
the
kubelet-configz
branch
from
86cbffc
to
20c923c
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #691 +/- ##
==========================================
+ Coverage 56.97% 57.19% +0.21%
==========================================
Files 566 566
Lines 54495 54495
==========================================
+ Hits 31049 31168 +119
+ Misses 19560 19419 -141
- Partials 3886 3908 +22
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
caohe
changed the title
luomingmeng
previously approved these changes
Sep 3, 2024
Signed-off-by: caohe <caohe9603@gmail.com>
luomingmeng
approved these changes
Sep 3, 2024
xu282934741
approved these changes
Sep 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Bug fixes
What this PR does / why we need it:
Extract the definition of
KubeletConfigurationfrom the kubelet API repository to the katalyst repository to adapt to incompatible changes of kubelet's/configzendpoint which were introduced by kubernetes/kubernetes#117800.Which issue(s) this PR fixes:
Special notes for your reviewer: