Skip to content

Commit

Permalink
Merge pull request openucx#6012 from dmitrygx/topic/ucp/gtest_wireup_…
Browse files Browse the repository at this point in the history
…test_skip_tcp

GTEST/UCP: Skip wireup 1sided disconnect test for TCP (workaround)
  • Loading branch information
yosefe authored Dec 11, 2020
2 parents 6e4d206 + 0e5d50f commit 2a60549
Showing 1 changed file with 9 additions and 1 deletion.
10 changes: 9 additions & 1 deletion test/gtest/ucp/test_ucp_wireup.cc
Original file line number Diff line number Diff line change
Expand Up @@ -630,7 +630,15 @@ UCS_TEST_P(test_ucp_wireup_1sided, send_disconnect_reply1) {
recv_b(sender().worker(), sender().ep(), 8, 1);
}

UCS_TEST_P(test_ucp_wireup_1sided, send_disconnect_reply2) {
UCS_TEST_SKIP_COND_P(test_ucp_wireup_1sided, send_disconnect_reply2,
/* skip the test for TCP, because it fails from time to
* time: the sender re-uses a socket fd from the already
* accepted connection from the receiver, but then the
* socket fd is closed, since the receiver closed the
* connection and the underlying TCP EP isn't able to
* receive the data on the failed socket.
* TODO: fix the bug on TCP level */
has_transport("tcp")) {
sender().connect(&receiver(), get_ep_params());

send_b(sender().ep(), 8, 1);
Expand Down

0 comments on commit 2a60549

Please sign in to comment.