Skip to content

Commit

Permalink
UCS/ARCH: Fix review comments
Browse files Browse the repository at this point in the history
Signed-off-by: JonasZhou <JonasZhou@zhaoxin.com>
  • Loading branch information
jonaszhou1 committed Nov 26, 2020
1 parent 85cc9ba commit ebbd95b
Show file tree
Hide file tree
Showing 4 changed files with 27 additions and 23 deletions.
29 changes: 15 additions & 14 deletions src/tools/info/sys_info.c
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
/**
* Copyright (C) Mellanox Technologies Ltd. 2001-2015. ALL RIGHTS RESERVED.
* Copyright (C) Shanghai Zhaoxin Semiconductor Co., Ltd. 2020. ALL RIGHTS RESERVED.
*
* See file LICENSE for terms.
*/
Expand All @@ -19,20 +20,20 @@


static const char* cpu_model_names[] = {
[UCS_CPU_MODEL_UNKNOWN] = "unknown",
[UCS_CPU_MODEL_INTEL_IVYBRIDGE] = "IvyBridge",
[UCS_CPU_MODEL_INTEL_SANDYBRIDGE] = "SandyBridge",
[UCS_CPU_MODEL_INTEL_NEHALEM] = "Nehalem",
[UCS_CPU_MODEL_INTEL_WESTMERE] = "Westmere",
[UCS_CPU_MODEL_INTEL_HASWELL] = "Haswell",
[UCS_CPU_MODEL_INTEL_BROADWELL] = "Broadwell",
[UCS_CPU_MODEL_INTEL_SKYLAKE] = "Skylake",
[UCS_CPU_MODEL_ARM_AARCH64] = "ARM 64-bit",
[UCS_CPU_MODEL_AMD_NAPLES] = "Naples",
[UCS_CPU_MODEL_AMD_ROME] = "Rome",
[UCS_CPU_MODEL_ZHAOXIN_Zhangjiang]= "Zhangjiang",
[UCS_CPU_MODEL_ZHAOXIN_Wudaokou] = "Wudaokou",
[UCS_CPU_MODEL_ZHAOXIN_Lujiazui] = "Lujiazui"
[UCS_CPU_MODEL_UNKNOWN] = "unknown",
[UCS_CPU_MODEL_INTEL_IVYBRIDGE] = "IvyBridge",
[UCS_CPU_MODEL_INTEL_SANDYBRIDGE] = "SandyBridge",
[UCS_CPU_MODEL_INTEL_NEHALEM] = "Nehalem",
[UCS_CPU_MODEL_INTEL_WESTMERE] = "Westmere",
[UCS_CPU_MODEL_INTEL_HASWELL] = "Haswell",
[UCS_CPU_MODEL_INTEL_BROADWELL] = "Broadwell",
[UCS_CPU_MODEL_INTEL_SKYLAKE] = "Skylake",
[UCS_CPU_MODEL_ARM_AARCH64] = "ARM 64-bit",
[UCS_CPU_MODEL_AMD_NAPLES] = "Naples",
[UCS_CPU_MODEL_AMD_ROME] = "Rome",
[UCS_CPU_MODEL_ZHAOXIN_ZHANGJIANG] = "Zhangjiang",
[UCS_CPU_MODEL_ZHAOXIN_WUDAOKOU] = "Wudaokou",
[UCS_CPU_MODEL_ZHAOXIN_LUJIAZUI] = "Lujiazui"
};

static const char* cpu_vendor_names[] = {
Expand Down
1 change: 1 addition & 0 deletions src/ucs/arch/cpu.c
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
/**
* Copyright (C) Mellanox Technologies Ltd. 2019. ALL RIGHTS RESERVED.
* Copyright (C) Shanghai Zhaoxin Semiconductor Co., Ltd. 2020. ALL RIGHTS RESERVED.
*
* See file LICENSE for terms.
*/
Expand Down
7 changes: 4 additions & 3 deletions src/ucs/arch/cpu.h
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
/**
* Copyright (C) Mellanox Technologies Ltd. 2001-2015. ALL RIGHTS RESERVED.
* Copyright (C) ARM Ltd. 2016. ALL RIGHTS RESERVED.
* Copyright (C) Shanghai Zhaoxin Semiconductor Co., Ltd. 2020. ALL RIGHTS RESERVED.
*
* See file LICENSE for terms.
*/
Expand Down Expand Up @@ -30,9 +31,9 @@ typedef enum ucs_cpu_model {
UCS_CPU_MODEL_ARM_AARCH64,
UCS_CPU_MODEL_AMD_NAPLES,
UCS_CPU_MODEL_AMD_ROME,
UCS_CPU_MODEL_ZHAOXIN_Zhangjiang,
UCS_CPU_MODEL_ZHAOXIN_Wudaokou,
UCS_CPU_MODEL_ZHAOXIN_Lujiazui,
UCS_CPU_MODEL_ZHAOXIN_ZHANGJIANG,
UCS_CPU_MODEL_ZHAOXIN_WUDAOKOU,
UCS_CPU_MODEL_ZHAOXIN_LUJIAZUI,
UCS_CPU_MODEL_LAST
} ucs_cpu_model_t;

Expand Down
13 changes: 7 additions & 6 deletions src/ucs/arch/x86_64/cpu.c
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
/**
* Copyright (C) Mellanox Technologies Ltd. 2001-2018. ALL RIGHTS RESERVED.
* Copyright (C) Advanced Micro Devices, Inc. 2019. ALL RIGHTS RESERVED.
* Copyright (C) Shanghai Zhaoxin Semiconductor Co., Ltd. 2020. ALL RIGHTS RESERVED.
*
* See file LICENSE for terms.
*/
Expand Down Expand Up @@ -340,20 +341,20 @@ ucs_cpu_model_t ucs_arch_get_cpu_model()
model = (version.ext_model << 4) | model;
}

if (ucs_arch_get_cpu_vendor() == UCS_CPU_VENDOR_ZHAOXIN){
if (family == 0x06){
switch (model){
if (ucs_arch_get_cpu_vendor() == UCS_CPU_VENDOR_ZHAOXIN) {
if (family == 0x06) {
switch (model) {
case 0x0f:
return UCS_CPU_MODEL_ZHAOXIN_Zhangjiang;
return UCS_CPU_MODEL_ZHAOXIN_ZHANGJIANG;
}
}

if (family == 0x07) {
switch (model) {
case 0x1b:
return UCS_CPU_MODEL_ZHAOXIN_Wudaokou;
return UCS_CPU_MODEL_ZHAOXIN_WUDAOKOU;
case 0x3b:
return UCS_CPU_MODEL_ZHAOXIN_Lujiazui;
return UCS_CPU_MODEL_ZHAOXIN_LUJIAZUI;
}
}
} else {
Expand Down

0 comments on commit ebbd95b

Please sign in to comment.