Skip to content

Commit

Permalink
Merge pull request #140 from kuzzleio/index-queryoptions
Browse files Browse the repository at this point in the history
Add query options argument in all Go/CGO/C++ functions
  • Loading branch information
jenow authored Mar 28, 2018
2 parents 29965aa + 15ee523 commit a906029
Show file tree
Hide file tree
Showing 21 changed files with 102 additions and 102 deletions.
4 changes: 2 additions & 2 deletions index/create.go
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import (
)

// Create a new empty data index, with no associated mapping.
func (i *Index) Create(index string) error {
func (i *Index) Create(index string, options types.QueryOptions) error {
if index == "" {
return types.NewError("Index.Create: index required", 400)
}
Expand All @@ -17,7 +17,7 @@ func (i *Index) Create(index string) error {
Controller: "index",
Action: "create",
}
go i.kuzzle.Query(query, nil, result)
go i.kuzzle.Query(query, options, result)

res := <-result

Expand Down
8 changes: 4 additions & 4 deletions index/create_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ import (
func TestCreateNull(t *testing.T) {
k, _ := kuzzle.NewKuzzle(&internal.MockedConnection{}, nil)
i := index.NewIndex(k)
err := i.Create("")
err := i.Create("", nil)
assert.NotNil(t, err)
}

Expand All @@ -28,7 +28,7 @@ func TestCreateQueryError(t *testing.T) {
}
k, _ := kuzzle.NewKuzzle(c, nil)
i := index.NewIndex(k)
err := i.Create("index")
err := i.Create("index", nil)
assert.NotNil(t, err)
}

Expand All @@ -52,7 +52,7 @@ func TestCreate(t *testing.T) {
}
k, _ := kuzzle.NewKuzzle(c, nil)
i := index.NewIndex(k)
err := i.Create("index")
err := i.Create("index", nil)

assert.Nil(t, err)
}
Expand All @@ -61,7 +61,7 @@ func ExampleIndex_Create() {
conn := websocket.NewWebSocket("localhost:7512", nil)
k, _ := kuzzle.NewKuzzle(conn, nil)
i := index.NewIndex(k)
err := i.Create("index")
err := i.Create("index", nil)
if err != nil {
fmt.Println(err.Error())
return
Expand Down
4 changes: 2 additions & 2 deletions index/delete.go
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ package index
import "github.com/kuzzleio/sdk-go/types"

// Delete the given index
func (i *Index) Delete(index string) error {
func (i *Index) Delete(index string, options types.QueryOptions) error {
if index == "" {
return types.NewError("Index.Delete: index required", 400)
}
Expand All @@ -15,7 +15,7 @@ func (i *Index) Delete(index string) error {
Controller: "index",
Action: "delete",
}
go i.kuzzle.Query(query, nil, result)
go i.kuzzle.Query(query, options, result)

res := <-result

Expand Down
10 changes: 5 additions & 5 deletions index/delete_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ import (
func TestDeleteNull(t *testing.T) {
k, _ := kuzzle.NewKuzzle(&internal.MockedConnection{}, nil)
i := index.NewIndex(k)
err := i.Delete("")
err := i.Delete("", nil)
assert.NotNil(t, err)
}

Expand All @@ -28,7 +28,7 @@ func TestDeleteQueryError(t *testing.T) {
}
k, _ := kuzzle.NewKuzzle(c, nil)
i := index.NewIndex(k)
err := i.Delete("index")
err := i.Delete("index", nil)
assert.NotNil(t, err)
}

Expand All @@ -52,7 +52,7 @@ func TestDelete(t *testing.T) {
}
k, _ := kuzzle.NewKuzzle(c, nil)
i := index.NewIndex(k)
err := i.Delete("index")
err := i.Delete("index", nil)

assert.Nil(t, err)
}
Expand All @@ -61,8 +61,8 @@ func ExampleIndex_Delete() {
conn := websocket.NewWebSocket("localhost:7512", nil)
k, _ := kuzzle.NewKuzzle(conn, nil)
i := index.NewIndex(k)
i.Create("index")
err := i.Delete("index")
i.Create("index", nil)
err := i.Delete("index", nil)
if err != nil {
fmt.Println(err.Error())
return
Expand Down
4 changes: 2 additions & 2 deletions index/exists.go
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ import (
)

// Exists check if the index exists
func (i *Index) Exists(index string) (bool, error) {
func (i *Index) Exists(index string, options types.QueryOptions) (bool, error) {
if index == "" {
return false, types.NewError("Index.Exists: index required", 400)
}
Expand All @@ -21,7 +21,7 @@ func (i *Index) Exists(index string) (bool, error) {
Action: "exists",
}

go i.kuzzle.Query(query, nil, result)
go i.kuzzle.Query(query, options, result)

res := <-result

Expand Down
10 changes: 5 additions & 5 deletions index/exists_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ import (
func TestExistsNull(t *testing.T) {
k, _ := kuzzle.NewKuzzle(&internal.MockedConnection{}, nil)
i := index.NewIndex(k)
_, err := i.Exists("")
_, err := i.Exists("", nil)
assert.NotNil(t, err)
}

Expand All @@ -28,7 +28,7 @@ func TestExistsQueryError(t *testing.T) {
}
k, _ := kuzzle.NewKuzzle(c, nil)
i := index.NewIndex(k)
_, err := i.Exists("index")
_, err := i.Exists("index", nil)
assert.NotNil(t, err)
}

Expand All @@ -53,7 +53,7 @@ func TestExists(t *testing.T) {

k, _ := kuzzle.NewKuzzle(c, nil)
i := index.NewIndex(k)
res, err := i.Exists("index")
res, err := i.Exists("index", nil)

assert.Nil(t, err)
assert.NotNil(t, res)
Expand All @@ -64,8 +64,8 @@ func ExampleIndex_Exists() {
conn := websocket.NewWebSocket("localhost:7512", nil)
k, _ := kuzzle.NewKuzzle(conn, nil)
i := index.NewIndex(k)
i.Create("index")
_, err := i.Exists("index")
i.Create("index", nil)
_, err := i.Exists("index", nil)
if err != nil {
fmt.Println(err.Error())
return
Expand Down
2 changes: 1 addition & 1 deletion index/getAutoRefresh.go
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import (
"github.com/kuzzleio/sdk-go/types"
)

func (i *Index) GetAutoRefresh(index string) (bool, error) {
func (i *Index) GetAutoRefresh(index string, options types.QueryOptions) (bool, error) {
if index == "" {
return false, types.NewError("Index.GetAutoRefresh: index required", 400)
}
Expand Down
10 changes: 5 additions & 5 deletions index/getAutoRefresh_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ import (
func TestGetAutoRefreshNull(t *testing.T) {
k, _ := kuzzle.NewKuzzle(&internal.MockedConnection{}, nil)
i := index.NewIndex(k)
_, err := i.GetAutoRefresh("")
_, err := i.GetAutoRefresh("", nil)
assert.NotNil(t, err)
}

Expand All @@ -28,7 +28,7 @@ func TestGetAutoRefreshQueryError(t *testing.T) {
}
k, _ := kuzzle.NewKuzzle(c, nil)
i := index.NewIndex(k)
_, err := i.GetAutoRefresh("index")
_, err := i.GetAutoRefresh("index", nil)
assert.NotNil(t, err)
}

Expand All @@ -53,7 +53,7 @@ func TestGetAutoRefresh(t *testing.T) {

k, _ := kuzzle.NewKuzzle(c, nil)
i := index.NewIndex(k)
_, err := i.GetAutoRefresh("index")
_, err := i.GetAutoRefresh("index", nil)

assert.Nil(t, err)
}
Expand All @@ -62,8 +62,8 @@ func ExampleIndex_GetAutoRefresh() {
conn := websocket.NewWebSocket("localhost:7512", nil)
k, _ := kuzzle.NewKuzzle(conn, nil)
i := index.NewIndex(k)
i.Create("index")
_, err := i.GetAutoRefresh("index")
i.Create("index", nil)
_, err := i.GetAutoRefresh("index", nil)
if err != nil {
fmt.Println(err.Error())
return
Expand Down
4 changes: 2 additions & 2 deletions index/list.go
Original file line number Diff line number Diff line change
Expand Up @@ -8,15 +8,15 @@ import (
)

// List list all index
func (i *Index) List() ([]string, error) {
func (i *Index) List(options types.QueryOptions) ([]string, error) {
result := make(chan *types.KuzzleResponse)

query := &types.KuzzleRequest{
Controller: "index",
Action: "list",
}

go i.kuzzle.Query(query, nil, result)
go i.kuzzle.Query(query, options, result)

res := <-result

Expand Down
6 changes: 3 additions & 3 deletions index/list_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ func TestListError(t *testing.T) {
k, _ := kuzzle.NewKuzzle(c, nil)

i := index.NewIndex(k)
_, err := i.List()
_, err := i.List(nil)
assert.NotNil(t, err)
assert.Equal(t, "Unit test error", err.(*types.KuzzleError).Message)
}
Expand All @@ -44,7 +44,7 @@ func TestList(t *testing.T) {
k, _ := kuzzle.NewKuzzle(c, nil)

i := index.NewIndex(k)
res, err := i.List()
res, err := i.List(nil)
expectedResponse := []string{"index_1", "index_2"}
assert.Nil(t, err)
assert.NotNil(t, res)
Expand All @@ -56,7 +56,7 @@ func ExampleIndex_List() {
k, _ := kuzzle.NewKuzzle(c, nil)

i := index.NewIndex(k)
res, err := i.List()
res, err := i.List(nil)

if err != nil {
fmt.Println(err.Error())
Expand Down
4 changes: 2 additions & 2 deletions index/mDelete.go
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ import (
)

// Delete delete the index
func (i *Index) MDelete(indexes []string) ([]string, error) {
func (i *Index) MDelete(indexes []string, options types.QueryOptions) ([]string, error) {
if len(indexes) == 0 {
return nil, types.NewError("Index.MDelete: at least one index required", 400)
}
Expand All @@ -20,7 +20,7 @@ func (i *Index) MDelete(indexes []string) ([]string, error) {
Action: "mDelete",
Body: indexes,
}
go i.kuzzle.Query(query, nil, result)
go i.kuzzle.Query(query, options, result)

res := <-result

Expand Down
12 changes: 6 additions & 6 deletions index/mDelete_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ func TestMDeleteNull(t *testing.T) {
k, _ := kuzzle.NewKuzzle(&internal.MockedConnection{}, nil)
i := index.NewIndex(k)
indexes := []string{}
_, err := i.MDelete(indexes)
_, err := i.MDelete(indexes, nil)
assert.NotNil(t, err)
}

Expand All @@ -30,7 +30,7 @@ func TestMDeleteQueryError(t *testing.T) {
k, _ := kuzzle.NewKuzzle(c, nil)
i := index.NewIndex(k)
indexes := []string{"index"}
_, err := i.MDelete(indexes)
_, err := i.MDelete(indexes, nil)
assert.NotNil(t, err)
}

Expand All @@ -55,7 +55,7 @@ func TestMDelete(t *testing.T) {
k, _ := kuzzle.NewKuzzle(c, nil)
i := index.NewIndex(k)
indexes := []string{"index1"}
res, err := i.MDelete(indexes)
res, err := i.MDelete(indexes, nil)

assert.Nil(t, err)
assert.NotNil(t, res)
Expand All @@ -66,13 +66,13 @@ func ExampleIndex_MDelete() {
conn := websocket.NewWebSocket("localhost:7512", nil)
k, _ := kuzzle.NewKuzzle(conn, nil)
i := index.NewIndex(k)
i.Create("index1")
i.Create("index2")
i.Create("index1", nil)
i.Create("index2", nil)
indexes := []string{
"index1",
"index2",
}
_, err := i.MDelete(indexes)
_, err := i.MDelete(indexes, nil)
if err != nil {
fmt.Println(err.Error())
return
Expand Down
4 changes: 2 additions & 2 deletions index/refresh.go
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import (
"github.com/kuzzleio/sdk-go/types"
)

func (i *Index) Refresh(index string) error {
func (i *Index) Refresh(index string, options types.QueryOptions) error {
if index == "" {
return types.NewError("Index.Refresh: index required", 400)
}
Expand All @@ -16,7 +16,7 @@ func (i *Index) Refresh(index string) error {
Action: "refresh",
Index: index,
}
go i.kuzzle.Query(query, nil, result)
go i.kuzzle.Query(query, options, result)

res := <-result

Expand Down
4 changes: 2 additions & 2 deletions index/refreshInternal.go
Original file line number Diff line number Diff line change
Expand Up @@ -2,15 +2,15 @@ package index

import "github.com/kuzzleio/sdk-go/types"

func (i *Index) RefreshInternal() error {
func (i *Index) RefreshInternal(options types.QueryOptions) error {

result := make(chan *types.KuzzleResponse)

query := &types.KuzzleRequest{
Controller: "index",
Action: "refreshInternal",
}
go i.kuzzle.Query(query, nil, result)
go i.kuzzle.Query(query, options, result)

res := <-result

Expand Down
6 changes: 3 additions & 3 deletions index/refreshInternal_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ func TestRefreshInternalQueryError(t *testing.T) {
}
k, _ := kuzzle.NewKuzzle(c, nil)
i := index.NewIndex(k)
err := i.RefreshInternal()
err := i.RefreshInternal(nil)
assert.NotNil(t, err)
}

Expand All @@ -44,7 +44,7 @@ func TestRefreshInternal(t *testing.T) {
}
k, _ := kuzzle.NewKuzzle(c, nil)
i := index.NewIndex(k)
err := i.RefreshInternal()
err := i.RefreshInternal(nil)

assert.Nil(t, err)
}
Expand All @@ -53,7 +53,7 @@ func ExampleIndex_RefreshInternal() {
conn := websocket.NewWebSocket("localhost:7512", nil)
k, _ := kuzzle.NewKuzzle(conn, nil)
i := index.NewIndex(k)
err := i.RefreshInternal()
err := i.RefreshInternal(nil)
if err != nil {
fmt.Println(err.Error())
return
Expand Down
Loading

0 comments on commit a906029

Please sign in to comment.