RELEASE 2.0.0 #243
Merged
RELEASE 2.0.0 #243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* remove pointers type on KuzzleError
…o KZL-70-cpp-e2e-tests
[bugfix] Fix document.validate unmarshalling
…cationResult to NotifcicationContent (#228)
## What does this PR do? Since users are now able to write their own protocol implemetation we check if the notifications channel are not nil before closing them. ### How should this be manually tested? See travis. :arrow_right: https://github.com/kuzzleio/sdk-cpp
fix collection.searchSpecifications by adding the missing query parameter.
Fix cancelSubs which was checking if notificationChannel was null before closing onReconnectChannel ... Bad copy paste I guess :p
#233 introduced a bug, making the SDK crashes when WebSocket is invoked without HTTP headers/with nil headers, since we try to dereference a nil value. This PR fixes the problem by adding a guard against nil HTTP headers. * [websocket] allow passing HTTP headers to the ctor * [bugfix] do not dereference a nil value
Fix websocket closing
…tion-links doc: updated docs links to doc v2
This PR fixes a segfault case occuring when closing an unconnected WebSocket instance.
## What does this PR do? Move the offline queue from the `Protocol` and `Websocket` to `Kuzzle`.
What does this PR do?
This PR add to Travis:
Linux: amd64, i386, arm64 and armhf.
MacOS: amd64 and i386.
Windows: amd64 and i386.
And enable Nightly Builds using cron jobs.
* [ci] Add cache, multiple Go version for Linux
* [ci] Add MacOS amd64 and Linux i386 builds
* [ci] Add windows amd64 build
* [ci] Add more and more environment
* [ci] Add ARM64 Linux build
* [ci] Add more ARMVx Linux builds
* [ci] Clean scripts
* [ci] Force execution on one core for arm builds
* [ci] Add conditions to builds
* [ci] Make latest Go version to 1.12.x
* [ci] Enable multi os builds for release PRs
* [ci] Add Slack notifications
* [review] Apply @benoitvidis suggestions
Make the SDK Go README looks like the SDK JS one. * [readme] Make README looks pretty * [review] Apply suggestions from @scottinet Co-Authored-By: alexandrebouthinon <bouthinon.alexandre@gmail.com>
The protocol.Connect method is supposed to return a boolean telling if this is a first connection, or a reconnection. Problem is, that status is computed at the beginning of that Connect method, and then set to true if this is a first connection, meaning that the status detection flag cannot be used. As a result, the event.Connected event is never triggered. Also, the event.Reconnected event is never triggered if no jwt is set.
alexandrebouthinon
approved these changes
Jun 5, 2019
Codecov Report
@@ Coverage Diff @@
## master #243 +/- ##
==========================================
- Coverage 89% 88.86% -0.14%
==========================================
Files 243 244 +1
Lines 4364 4463 +99
==========================================
+ Hits 3884 3966 +82
+ Misses 453 443 -10
- Partials 27 54 +27
Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #243 +/- ##
==========================================
- Coverage 89% 88.86% -0.14%
==========================================
Files 243 244 +1
Lines 4364 4463 +99
==========================================
+ Hits 3884 3966 +82
+ Misses 453 443 -10
- Partials 27 54 +27
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2.0.0 (2019-06-05)
Breaking changes
Bug fixes
New features
Enhancements
Others
Optimizations