Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Color river shores / waterfalls with shores / cliffs differently #251

Open
Corgano opened this issue May 25, 2020 · 15 comments
Open

Color river shores / waterfalls with shores / cliffs differently #251

Corgano opened this issue May 25, 2020 · 15 comments
Labels
enhancement New feature or request good issue A good issue that someone should research

Comments

@Corgano
Copy link

Corgano commented May 25, 2020

Currently, All river / water tiles (and cliffs!) appear the same in the editor, making it VERY difficult to edit rivers without remembering the ID's of each corner, plus their orientation. This also applies to waterfalls!

I don't know if the field item editor (more a map editor at this point) supports graphics for the tiles, but it would REALLY help if there was some differentiation.

image
In this example I colored some of the tiles to make it MUCH more apparent what kind of river / waterfall they are. It is immiedietly obvious what each tile is. Before all the river tiles were just straight blue! The same can be done for cliffs - they behave very similarly.

@Corgano Corgano added the enhancement New feature or request label May 25, 2020
@kwsch
Copy link
Owner

kwsch commented May 25, 2020

Would need information on what each tile type/rotation/variant needs to look like when drawn; there's a LOT of combinations that I don't want to document (myself).

@Corgano
Copy link
Author

Corgano commented May 25, 2020

Tell me what format you want the list in and I'll document it. I've struggled with this for long enough that I remember a quarter of them

@kwsch
Copy link
Owner

kwsch commented May 25, 2020

List of terrain models

Would need a spreadsheet of sorts listing:

model | variant | rotation | appearance

a model can have multiple variants, and each of those permutations can be rotated. You can probably get away with describing just model-variant permutations, since rotations are likely a 90degree turn (same for all).

@Corgano
Copy link
Author

Corgano commented May 25, 2020

what i found is for river / cliff sections, all the variant does is give it a slight texture change to make it look less samey. You could easily randomize variant for these tiles with no functional difference, but a very slight graphical variation.

There should be a checkbox for random variant added to the field item editor, it;d actually be quite handy

I'll work on making a sheet up today and tomorrow

@Possum80
Copy link

Agree with the above. Select and copy/change to the wrong tile, and that part of map becomes glitchy in game, with see through areas or areas you cannot change or interact with in game.

@Corgano
Copy link
Author

Corgano commented May 26, 2020

test save - tile types.zip
I made a save file that has one of every tile, in all rotations. I can upload somewhere if you like. Working on the list now

@Corgano
Copy link
Author

Corgano commented May 26, 2020

@Corgano
Copy link
Author

Corgano commented May 26, 2020

Done river and cliffs. waterfalls are going to be a pain to try and describe because they deal with water, cliffs, and land. figured out how you're going to draw them yet?

@Corgano
Copy link
Author

Corgano commented May 28, 2020

Edit: All tiles done! some descriptions are missing, but all ground tiles have been documented!
Tiles.zip
https://docs.google.com/spreadsheets/d/12LOYvdpuKxqYc9cuDfMc3PawgVv8mFcOVn6x449kU9s

@Corgano
Copy link
Author

Corgano commented May 30, 2020

Any update on this? I'd work on implementing it myself but I've never used C# before.

@Possum80
Copy link

Open issues are essentially a 'to do' list. Some can be done easily, and others will take time. Just give the developers time.

@Possum80
Copy link

Possum80 commented Jun 7, 2020

Corgano, the list you posted is missing data for inclines

@Corgano
Copy link
Author

Corgano commented Jun 7, 2020 via email

Repository owner deleted a comment from Anonymous42456 Jan 26, 2021
@Corgano
Copy link
Author

Corgano commented Jan 26, 2021 via email

@Elfykins
Copy link

I know this is a necro, but I am sad that this was never implemented, you did amazing work getting them all done, and it would have been absolutely awesome to have them in the editor!

@berichan berichan added the good issue A good issue that someone should research label Dec 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good issue A good issue that someone should research
Projects
None yet
Development

No branches or pull requests

5 participants