Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement CI for helm chart #15

Merged
merged 11 commits into from
Mar 17, 2021
Merged

Implement CI for helm chart #15

merged 11 commits into from
Mar 17, 2021

Conversation

kolikons
Copy link
Contributor

Added CI github action for cheking syntax helm charts

Important:
If you made some changes in dependency chart. You have to perfrom to build Chart.lock file before you push commit into repo

helm dependency build policy-reporter
or
helm dependency update policy-reporter

tests:

 ct lint --lint-conf=.github/ct_lintconf.yaml --chart-yaml-schema=.github/ct_chart_schema.yaml --validate-maintainers=false   --target-branch=main --chart-dirs charts
Linting charts...

------------------------------------------------------------------------------------------------------------------------
 Charts to be processed:
------------------------------------------------------------------------------------------------------------------------
 policy-reporter => (version: "0.17.1", path: "charts/policy-reporter")
------------------------------------------------------------------------------------------------------------------------

Hang tight while we grab the latest from your chart repositories...
Update Complete. ⎈Happy Helming!⎈
Saving 2 charts
Dependency monitoring did not declare a repository. Assuming it exists in the charts directory
Dependency policy-reporter-ui did not declare a repository. Assuming it exists in the charts directory
Deleting outdated charts
Linting chart 'policy-reporter => (version: "0.17.1", path: "charts/policy-reporter")'
Checking chart 'policy-reporter => (version: "0.17.1", path: "charts/policy-reporter")' for a version bump...
Old chart version: 0.17.0
New chart version: 0.17.1
Chart version ok.
Validating /github/policy-reporter/charts/policy-reporter/Chart.yaml...
Validation success! 👍
==> Linting charts/policy-reporter
[INFO] Chart.yaml: icon is recommended

1 chart(s) linted, 0 chart(s) failed
------------------------------------------------------------------------------------------------------------------------
 ✔︎ policy-reporter => (version: "0.17.1", path: "charts/policy-reporter")
------------------------------------------------------------------------------------------------------------------------
All charts linted successfully

FYI: if you want to implement e2e test, you can create use for example: https://github.com/helm/chart-testing/tree/master/examples/kind

@kolikons
Copy link
Contributor Author

@fjogeleit fjogeleit self-requested a review March 17, 2021 00:22
@fjogeleit fjogeleit added the enhancement New feature or request label Mar 17, 2021
@fjogeleit
Copy link
Member

Great improvement, thanks a lot! I will have a look on the e2e stuff.

@fjogeleit fjogeleit merged commit cdf6686 into kyverno:main Mar 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants