Customize label and annotation for Grafana dashboards #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
nlamirault
commented
Jun 26, 2021
nlamirault
commented
- Add a feature to customize the label on the configmap to discover Grafana dashboards.
- Add an annotation to support Grafana folder name into the configmap.
Signed-off-by: Nicolas Lamirault <nicolas.lamirault@gmail.com>
Signed-off-by: Nicolas Lamirault <nicolas.lamirault@gmail.com>
fjogeleit
requested changes
Jun 26, 2021
| # Annotation to enable folder storage using the k8s sidecar | ||
| annotation: grafana_folder | ||
| # Grafana folder in which to store the dashboards | ||
| name: kyverno |
There was a problem hiding this comment.
I know that the primary use case of Policy Reporter is currently the combination with Kyverno but in its core, Policy Reporter Dashboards are useful for all Tools using the PolicyReport CRDs. So I would prefer to use a more generic default.
Suggested change
| name: kyverno | |
| name: Policy Reporter |
Signed-off-by: Nicolas Lamirault <nicolas.lamirault@gmail.com>
Signed-off-by: Nicolas Lamirault <nicolas.lamirault@gmail.com>
fjogeleit
approved these changes
Jun 26, 2021
fjogeleit
requested changes
Jun 26, 2021
fjogeleit
approved these changes
Jun 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.