feat: add an optional second parameter to trigger extrakto with a spe…

[marcdeop]

This allow us to trigger extrakto with a specific filter in mind.

For example running open.sh 0 url will open with the url filter (and only that one):

Thanks to the restore_original() function, our settings for extrakto will remain the same.

This opens the possibility of having custom key-bindings like:

tmux bind-key u run-shell "\"$extrakto_open\" \"#{pane_id}\" url"

To trigger extracto with our needed filter in mind :-)

[laktak]

Thanks for your PR!

I like your idea but could you change the implementation to pass the filter along instead of temporarily changing the option?

For example tmux allows you to pass an env. variable to the new process:

 -e takes the form ‘VARIABLE=value’ and sets an environment variable 
 for the popup; it may be specified multiple times.

You could pass along extrakto_inital_mode and return that in the get_next_mode() function for if [ $next == "initial" ].

[marcdeop]

Thanks for your PR!

I like your idea but could you change the implementation to pass the filter along instead of temporarily changing the option?

For example tmux allows you to pass an env. variable to the new process:

 -e takes the form ‘VARIABLE=value’ and sets an environment variable 
 for the popup; it may be specified multiple times.

You could pass along extrakto_inital_mode and return that in the get_next_mode() function for if [ $next == "initial" ].

I will have a look!

[marcdeop]

I think your proposal is WAY more elegant than what I did.

Please have a look at how I implemented it this time @laktak

[laktak]

Looking good! Just one thing - please change EXTRAKTO_INITAL_MODE to lowercase (shell naming conventions) before I merge it.

We also have a new branch (https://github.com/laktak/extrakto/tree/python-posix) if you are interested, but I can update that one later.

[marcdeop]

Looking good! Just one thing - please change EXTRAKTO_INITAL_MODE to lowercase (shell naming conventions) before I merge it.

I made it lowercase

We also have a new branch (https://github.com/laktak/extrakto/tree/python-posix) if you are interested, but I can update that one later.

Is this a long term thing or are you planning on merging this soon?

[laktak]

Thank you! :)

Is this a long term thing or are you planning on merging this soon?

Depends on how stable it is but I'd rather switch to it soon.