Define minimum length per filter #124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your PR, I think it's a good idea! Since extrakto can be used a a module and via the cli as well, could you update your PR to avoid breaking changes? IMHO it should only use min_length from the filter if no min_length param/arg was specified. Thanks :) |
Sure! I don't know why I haven't thought of that 😅 I'll also fix the formatting issue, so black will be happy :) |
|
Alright, I fixed the formatting issue and made the global min_length (if present) overwrite a filter's min_length. Since the tests pass (at least on my machine xD) I would assume, that there are no more breaking changes :) |
laktak
requested changes
Jun 27, 2024
|
Thanks for your patience! I fixed the two issues you mentioned. |
laktak
approved these changes
Jun 30, 2024
|
Looking good, thank you! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, extracto uses the same minimum length for all filters. This PR introduces an optional config key to change the minimum length for each filter individually. The default value is still five, though.