fix: join the shell opts to a string in suda#systemlist

[aarondill]

This avoids an error on vim.
fixes #77

Summary by CodeRabbit

• Refactor
  • Improved command string construction in the Suda plugin to enhance compatibility and potential future enhancements.

[coderabbitai]

Walkthrough

The update to suda.vim modifies how command strings are constructed based on the g:suda#executable setting, addressing an issue where lists were improperly used as strings. This change enhances the plugin's compatibility and stability.

Changes

File	Change Summary
autoload/suda.vim	Modified s:get_command to handle command construction and -- usage based on g:suda#executable. Added comments for future code enhancements.

Assessment against linked issues

Objective	Addressed	Explanation
[suda] Vim(let):E730: Using a List as a String (#77)	✅

Poem

In the garden of code, where the functions bloom, 🌼
A rabbit tweaked the strings under the moon. 🌙
No more lists as strings, errors take flight,
With every line of code, we set things right.
Hop, hop, hooray, for the bugs we chase,
In the soft glow of the screen, our perfect place. 🐇💻

---

Recent Review Details

Configuration used: CodeRabbit UI

Commits

Files that changed from the base of the PR and between d0ccc1a and 0be5821.

Files selected for processing (1)

• autoload/suda.vim (1 hunks)

Additional comments not posted (2)

autoload/suda.vim (2)

6-19: The modifications in s:get_command correctly address the issue of using a list as a string by ensuring proper string construction. However, the presence of multiple TODO comments suggests areas for future improvement.

Consider addressing the TODO comments to enhance the maintainability and clarity of the function. Would you like assistance in defining these enhancements more concretely?

---

3-22: > 📝 NOTE

This review was outside the diff hunks and was mapped to the diff hunk with the greatest overlap. Original lines [20-60]

The integration of s:get_command in suda#systemlist appears correct. The handling of non-interactive commands is complex and should be thoroughly tested to ensure reliability.

Please ensure that the non-interactive command handling is thoroughly tested, especially in environments where suda#executable might differ. Would you like a test script to verify this functionality across different configurations?

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[aarondill]

I'm working on testing this on vim, please don't merge this yet.

[aarondill]

Okay, I've successfully tested this on VIM - Vi IMproved 9.1 and NVIM v0.10.0-dev-2702+g0c0be09ea-dirty!
This is ready to merge @lambdalisue