-
Notifications
You must be signed in to change notification settings - Fork 15k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
core[minor], integrations...[patch]: Support ToolCall as Tool input and ToolMessage as Tool output #24038
Merged
Merged
core[minor], integrations...[patch]: Support ToolCall as Tool input and ToolMessage as Tool output #24038
Changes from all commits
Commits
Show all changes
33 commits
Select commit
Hold shift + click to select a range
8eb1776
rfc: sep methd for tool message res
baskaryan 2474dcd
fmt
baskaryan a2d8652
fmt
baskaryan 0d42f29
fmt
baskaryan f688f87
fmt
baskaryan 0cd8bb9
fmt
baskaryan 4525856
fmt
baskaryan f1b3b27
fmt
baskaryan 3fc90ec
fmt
baskaryan fb11a47
fmt
baskaryan 7ebf05d
Merge branch 'master' into bagatur/rfc_sep_method_for_tool_res
baskaryan b43bf00
fmt
baskaryan 5c88785
fmt
baskaryan 0f42560
fmt
baskaryan 4abc681
fmt
baskaryan a2e9fb8
Merge branch 'master' into bagatur/rfc_sep_method_for_tool_res
baskaryan ccbc750
fmt
baskaryan d7d5a80
fmt
baskaryan 7aefb5f
fmt
baskaryan f6f5894
fmt
baskaryan 20c05ae
Merge branch 'master' into bagatur/rfc_sep_method_for_tool_res
efriis 8b45880
fmt
baskaryan 72aa42c
Merge branch 'bagatur/rfc_sep_method_for_tool_res' of github.com:lang…
baskaryan 50cd03a
fmt
baskaryan 2e81755
fmt
baskaryan c24cf5d
fmt
baskaryan 9228c58
fmt
baskaryan b525d5e
fmt
baskaryan 844586a
fmt
baskaryan 03bcf88
fmt
baskaryan 82ec9f9
fmt
baskaryan 59ce038
Merge branch 'master' into bagatur/rfc_sep_method_for_tool_res
baskaryan 32e4073
fmt
baskaryan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why is this needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
convenience / to make sure ppl don't mess up the type
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How is that easier than using ToolCallChunk? Is it validating that there are no extra arguments or typos in the arguments?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
type is hard coded