Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

langchain-pinecone: add id to similarity documents results #25630

Merged
merged 3 commits into from
Aug 22, 2024

Conversation

yahya-mouman
Copy link
Contributor

@yahya-mouman yahya-mouman commented Aug 21, 2024

  • Description: This change adds the ID field that's required in Pinecone to the result documents of the similarity search method.

  • Issue: Lack of document metadata namely the ID field

  • Add tests and docs: If you're adding a new integration, please include

    1. a test for the integration, preferably unit tests that do not rely on network access,
    2. an example notebook showing its use. It lives in docs/docs/integrations directory.
  • Lint and test: Run make format, make lint and make test from the root of the package(s) you've modified. See contribution guidelines for more: https://python.langchain.com/docs/contributing/

Additional guidelines:

  • Make sure optional dependencies are imported within a function.
  • Please do not add dependencies to pyproject.toml files (even optional ones) unless they are required for unit tests.
  • Most PRs should not touch more than one package.
  • Changes should be backwards compatible.
  • If you are adding something to community, do not re-import it in langchain.

If no one reviews your PR within a few days, please @-mention one of baskaryan, efriis, eyurtsev, ccurme, vbarda, hwchase17.

@efriis efriis added the partner label Aug 21, 2024
@efriis efriis self-assigned this Aug 21, 2024
Copy link

vercel bot commented Aug 21, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
langchain ⬜️ Ignored (Inspect) Visit Preview Aug 22, 2024 6:32pm

@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. 🔌: pinecone Primarily related to Pinecone vector store integration 🤖:nit Small modifications/deletions, fixes, deps or improvements to existing code or docs labels Aug 21, 2024
@dosubot dosubot bot added the lgtm PR looks good. Use to confirm that a PR is ready for merging. label Aug 22, 2024
@ccurme ccurme enabled auto-merge (squash) August 22, 2024 18:32
@ccurme ccurme merged commit e5bb4cb into langchain-ai:master Aug 22, 2024
16 checks passed
@yahya-mouman yahya-mouman changed the title lagchain-pinecone: add id to similarity documents results langchain-pinecone: add id to similarity documents results Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm PR looks good. Use to confirm that a PR is ready for merging. 🤖:nit Small modifications/deletions, fixes, deps or improvements to existing code or docs partner 🔌: pinecone Primarily related to Pinecone vector store integration size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants