Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core[patch]: Support non ASCII characters in tool output if user doesn't output string #26319

Merged
merged 1 commit into from
Sep 11, 2024

Conversation

GyuminJack
Copy link
Contributor

simple modify

core: add supporting non english character

target issue is #26315
same issue on langgraph - langchain-ai/langgraph#1504

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Sep 11, 2024
Copy link

vercel bot commented Sep 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
langchain ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 11, 2024 0:11am

@dosubot dosubot bot added Ɑ: core Related to langchain-core 🤖:bug Related to a bug, vulnerability, unexpected error with an existing feature labels Sep 11, 2024
@eyurtsev eyurtsev changed the title [FIX] support json.dumps non-english character core[patch]: Support non ASCII characters in tool output if user doesn't output string Sep 11, 2024
@eyurtsev eyurtsev enabled auto-merge (squash) September 11, 2024 15:12
@dosubot dosubot bot added the lgtm PR looks good. Use to confirm that a PR is ready for merging. label Sep 11, 2024
@eyurtsev eyurtsev merged commit 7feae62 into langchain-ai:master Sep 11, 2024
87 checks passed
Sheepsta300 pushed a commit to Sheepsta300/langchain that referenced this pull request Oct 1, 2024
…n't output string (langchain-ai#26319)

### simple modify
core: add supporting non english character

target issue is langchain-ai#26315 
same issue on langgraph -
langchain-ai/langgraph#1504
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🤖:bug Related to a bug, vulnerability, unexpected error with an existing feature Ɑ: core Related to langchain-core lgtm PR looks good. Use to confirm that a PR is ready for merging. size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants