feat: key components health check #2510
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
size:L
ogabrielluiz
requested changes
Jul 3, 2024
| logger.exception(e) | ||
|
|
||
| if response.has_error(): | ||
| raise HTTPException(status_code=status.HTTP_500_INTERNAL_SERVER_ERROR, detail=response.model_dump()) |
There was a problem hiding this comment.
When we dump this, should the parameter include the error?
e.g.
try:
create_default_folder_if_it_doesnt_exist(session, uuid.UUID(user_id))
response.folder = "ok"
except Exception as e:
logger.exception(e)
response.folder = e.message()
There was a problem hiding this comment.
Good suggestion. I will do another PR to improve that.
jordanrfrazier
approved these changes
Jul 3, 2024
ogabrielluiz
approved these changes
Jul 3, 2024
nicoloboschi
reviewed
Jul 4, 2024
There was a problem hiding this comment.
- This portion of the code needs to be changed. This makes the health check not idempotent and not able to run in parallel, which is problematic in many scenarios. For example, in k8s liveness and readiness probe could run in parallel.
It's ok to write/read to the cache but there's no need to verify the correctness, we should just check the availability.
await chat.set_cache("health_check", str(test_id))
if v := await chat.get_cache("health_check"):
if v.get("result") == str(test_id):
response.chat = "ok"
else:
logger.error("chat service get incorrect value")
- I don't see the value of testing the variable service. If variables are on the db, you're testing the DB (again!) and if they are on k8s it's very expensive and not worth it (if you're on k8s, k8s is up..)
Also you're leaking the variable in case the deletion fails.
I would completely remove the variable section.
- Again for the folder section, there's no need to test the DB connectivity again.
ogabrielluiz
pushed a commit
to yaitec/langflow
that referenced
this pull request
Jul 9, 2024
key components health check
nicoloboschi
pushed a commit
to datastax/ragstack-ai-langflow
that referenced
this pull request
Jul 10, 2024
key components health check (cherry picked from commit a2ec87b)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since /health is also supported by uvicorn, so until the langflow's router is initialized.
/healthreturns the status of uvicorn. That does not reflect the readiness of the langflow.This PR introduces a new endpoint
/health_checkthat also test key services like chat, session, and variable services that make sure cache , DB, or kubernetes backend are working. It offers more reliable service type of check rather a simple route basedhealthcheck. Only a few selected services to save the health check time.Once this PR is merged and released, Kubernetes's probe should use the /health_check endpoint.