Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: migrate text splitters to Component syntax #2530

Merged
merged 3 commits into from
Jul 4, 2024
Merged

feat: migrate text splitters to Component syntax #2530

merged 3 commits into from
Jul 4, 2024

Conversation

nicoloboschi
Copy link
Contributor

No description provided.

@dosubot dosubot bot added size:XXL This PR changes 1000+ lines, ignoring generated files. enhancement New feature or request python Pull requests that update Python code labels Jul 4, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 4, 2024

Pull Request Validation Report

This comment is automatically generated by Conventional PR

Whitelist Report

Whitelist Active Result
Pull request is a draft and should be ignored ✅ ❌
Pull request is made by a whitelisted user and should be ignored ❌ ❌
Pull request is submitted by a bot and should be ignored ✅ ❌
Pull request is submitted by administrators and should be ignored ❌ ❌

Result

Pull request does not satisfy any enabled whitelist criteria. Pull request will be validated.

Validation Report

Validation Active Result
All commits in this pull request has valid messages ❌ ✅
Pull request does not introduce too many changes ❌ ✅
Pull request has a valid title ✅ ✅
Pull request has valid branch name ❌ ✅
Pull request should have a non-empty body ✅ ❌
Pull request has mentioned issues ✅ ❌

Result

Pull request is invalid.

Reason

  • Pull request must have a non-empty body
  • Pull request does not mention any issues

Last Modified at 04 Jul 24 13:57 UTC

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 4, 2024

Pull Request Validation Report

This comment is automatically generated by Conventional PR

Whitelist Report

Whitelist Active Result
Pull request is a draft and should be ignored ✅ ❌
Pull request is made by a whitelisted user and should be ignored ❌ ❌
Pull request is submitted by a bot and should be ignored ✅ ❌
Pull request is submitted by administrators and should be ignored ❌ ❌

Result

Pull request does not satisfy any enabled whitelist criteria. Pull request will be validated.

Validation Report

Validation Active Result
All commits in this pull request has valid messages ❌ ✅
Pull request does not introduce too many changes ❌ ✅
Pull request has a valid title ✅ ✅
Pull request has valid branch name ❌ ✅
Pull request should have a non-empty body ✅ ❌
Pull request has mentioned issues ✅ ❌

Result

Pull request is invalid.

Reason

  • Pull request must have a non-empty body
  • Pull request does not mention any issues

Last Modified at 04 Jul 24 13:58 UTC

ogabrielluiz
ogabrielluiz approved these changes Jul 4, 2024
View reviewed changes
Copy link
Contributor

@ogabrielluiz ogabrielluiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jul 4, 2024
@ogabrielluiz ogabrielluiz enabled auto-merge (squash) July 4, 2024 15:14
@Cristhianzl
Copy link
Collaborator

@nicoloboschi
I'm checking the tests, ok?

@ogabrielluiz ogabrielluiz merged commit 86aaab0 into langflow-ai:main Jul 4, 2024
21 of 27 checks passed
ogabrielluiz added a commit to yaitec/langflow that referenced this pull request Jul 9, 2024
@nicoloboschi @autofix-ci @ogabrielluiz
feat: migrate text splitters to Component syntax (langflow-ai#2530)
b6bf452 
* feat: migrate text splitters to Component syntax

* [autofix.ci] apply automated fixes

---------

Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
Co-authored-by: Gabriel Luiz Freitas Almeida <gabriel@langflow.org>
nicoloboschi added a commit to datastax/ragstack-ai-langflow that referenced this pull request Jul 10, 2024
@nicoloboschi
feat: migrate text splitters to Component syntax (langflow-ai#2530)
a6f4d9a 
* feat: migrate text splitters to Component syntax

* [autofix.ci] apply automated fixes

---------

Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
Co-authored-by: Gabriel Luiz Freitas Almeida <gabriel@langflow.org>
(cherry picked from commit 86aaab0)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ogabrielluiz ogabrielluiz ogabrielluiz approved these changes

Assignees
No one assigned
Labels
conventional: enhancement enhancement New feature or request lgtm This PR has been approved by a maintainer python Pull requests that update Python code size:XXL This PR changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nicoloboschi @Cristhianzl @ogabrielluiz