test: Add New Test for Freeze Path Feature and Improve Existing Tests #2833
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t for testing purposes 🐛 (end-to-end tests): Update test selectors to match changes in component names for consistency and accuracy ✨ (freeze-path.spec.ts): Add end-to-end test for user ability to freeze a path in the application 🐛 (generalBugs-shard-0.spec.ts): Fix outdated component selector in end-to-end test for clearing chat messages 🐛 (generalBugs-shard-1.spec.ts): Fix outdated component selector in end-to-end test for deleting rows from a table message 🐛 (generalBugs-shard-3.spec.ts): Fix outdated component issue by updating the selector for the AlertTriangle icon and the API key input field, and selecting a different model option 🐛 (logs.spec.ts): Fix outdated component issue by updating the selector for the AlertTriangle icon and the API key input field, and selecting a different model option. Also, ensure the "built successfully" text is clicked within a specified timeout 🐛 (textInputOutput.spec.ts): Fix outdated component issue by updating the selector for the AlertTriangle icon and the API key input field, and selecting a different model option
dosubot
bot
added
size:L
…e updated shardIndex values for better test distribution.
Pull Request Validation ReportThis comment is automatically generated by Conventional PR Whitelist Report
Result Pull request does not satisfy any enabled whitelist criteria. Pull request will be validated. Validation Report
Result Pull request satisfies all enabled pull request rules. Last Modified at 19 Jul 24 15:35 UTC |
github-actions
bot
added
test
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
… and checking collection name input field in InputComponent test to improve test focus and readability.
…into cz/test-freezepath
…nt is checked after clicking on it
dosubot
bot
added
size:XXL
…le both array and non-array values more efficiently 🔧 (inputComponent.spec.ts, intComponent.spec.ts, saveComponents.spec.ts): Update file paths to point to the correct location of test assets
…for helpersChat Memory and agentsTool Calling Agent to prevent test failures 📝 (folders.spec.ts): update file path to read collection.json from the correct location 📝 (saveComponents.spec.ts): update file path to read flow_group_test.json from the correct location
dosubot
bot
added
size:XL
…om 16 to 20 to distribute tests more evenly across shards.
… fix file not found error
…ntsCSVAgent element instead of agentsTool Calling Agent element 🐛 (folders.spec.ts): increase timeout for page.waitForTimeout to 5000ms and add a comment suggesting to consider using a more reliable waiting mechanism. Also, add a comment to wait for the target element to be available before evaluation.
…into cz/test-freezepath
anovazzi1
pushed a commit
that referenced
this pull request
Jul 22, 2024
…#2833) * 📝 (floatComponent/index.tsx): Add data-testid attribute to float input for testing purposes 🐛 (end-to-end tests): Update test selectors to match changes in component names for consistency and accuracy ✨ (freeze-path.spec.ts): Add end-to-end test for user ability to freeze a path in the application 🐛 (generalBugs-shard-0.spec.ts): Fix outdated component selector in end-to-end test for clearing chat messages 🐛 (generalBugs-shard-1.spec.ts): Fix outdated component selector in end-to-end test for deleting rows from a table message 🐛 (generalBugs-shard-3.spec.ts): Fix outdated component issue by updating the selector for the AlertTriangle icon and the API key input field, and selecting a different model option 🐛 (logs.spec.ts): Fix outdated component issue by updating the selector for the AlertTriangle icon and the API key input field, and selecting a different model option. Also, ensure the "built successfully" text is clicked within a specified timeout 🐛 (textInputOutput.spec.ts): Fix outdated component issue by updating the selector for the AlertTriangle icon and the API key input field, and selecting a different model option * ⬆️ (typescript_test.yml): increase shardTotal value to 16 to match the updated shardIndex values for better test distribution. * 📝 (inputComponent.spec.ts): remove unnecessary test case for clicking and checking collection name input field in InputComponent test to improve test focus and readability. * Revert "refactor: update template api, handleonnewvalue and handlenodeclass hooks (#2628)" This reverts commit b3c1b94. * ✅ (inputComponent.spec.ts): add test case to check if the input element is checked after clicking on it * ✨ (multiselectComponent/index.tsx): Refactor value assignment to handle both array and non-array values more efficiently 🔧 (inputComponent.spec.ts, intComponent.spec.ts, saveComponents.spec.ts): Update file paths to point to the correct location of test assets * ✅ (filterSidebar.spec.ts): comment out two failing test expectations for helpersChat Memory and agentsTool Calling Agent to prevent test failures 📝 (folders.spec.ts): update file path to read collection.json from the correct location 📝 (saveComponents.spec.ts): update file path to read flow_group_test.json from the correct location * ⬆️ (typescript_test.yml): increase the number of shardIndex values from 16 to 20 to distribute tests more evenly across shards. * 📝 (folders.spec.ts): update file path to read collection.json file to fix file not found error * add condition to merge-reports * ✅ (filterSidebar.spec.ts): update test to check for visibility of agentsCSVAgent element instead of agentsTool Calling Agent element 🐛 (folders.spec.ts): increase timeout for page.waitForTimeout to 5000ms and add a comment suggesting to consider using a more reliable waiting mechanism. Also, add a comment to wait for the target element to be available before evaluation. --------- Co-authored-by: Gabriel Luiz Freitas Almeida <gabriel@langflow.org>
nicoloboschi
pushed a commit
to datastax/ragstack-ai-langflow
that referenced
this pull request
Jul 30, 2024
…langflow-ai#2833) * 📝 (floatComponent/index.tsx): Add data-testid attribute to float input for testing purposes 🐛 (end-to-end tests): Update test selectors to match changes in component names for consistency and accuracy ✨ (freeze-path.spec.ts): Add end-to-end test for user ability to freeze a path in the application 🐛 (generalBugs-shard-0.spec.ts): Fix outdated component selector in end-to-end test for clearing chat messages 🐛 (generalBugs-shard-1.spec.ts): Fix outdated component selector in end-to-end test for deleting rows from a table message 🐛 (generalBugs-shard-3.spec.ts): Fix outdated component issue by updating the selector for the AlertTriangle icon and the API key input field, and selecting a different model option 🐛 (logs.spec.ts): Fix outdated component issue by updating the selector for the AlertTriangle icon and the API key input field, and selecting a different model option. Also, ensure the "built successfully" text is clicked within a specified timeout 🐛 (textInputOutput.spec.ts): Fix outdated component issue by updating the selector for the AlertTriangle icon and the API key input field, and selecting a different model option * ⬆️ (typescript_test.yml): increase shardTotal value to 16 to match the updated shardIndex values for better test distribution. * 📝 (inputComponent.spec.ts): remove unnecessary test case for clicking and checking collection name input field in InputComponent test to improve test focus and readability. * Revert "refactor: update template api, handleonnewvalue and handlenodeclass hooks (langflow-ai#2628)" This reverts commit b3c1b94. * ✅ (inputComponent.spec.ts): add test case to check if the input element is checked after clicking on it * ✨ (multiselectComponent/index.tsx): Refactor value assignment to handle both array and non-array values more efficiently 🔧 (inputComponent.spec.ts, intComponent.spec.ts, saveComponents.spec.ts): Update file paths to point to the correct location of test assets * ✅ (filterSidebar.spec.ts): comment out two failing test expectations for helpersChat Memory and agentsTool Calling Agent to prevent test failures 📝 (folders.spec.ts): update file path to read collection.json from the correct location 📝 (saveComponents.spec.ts): update file path to read flow_group_test.json from the correct location * ⬆️ (typescript_test.yml): increase the number of shardIndex values from 16 to 20 to distribute tests more evenly across shards. * 📝 (folders.spec.ts): update file path to read collection.json file to fix file not found error * add condition to merge-reports * ✅ (filterSidebar.spec.ts): update test to check for visibility of agentsCSVAgent element instead of agentsTool Calling Agent element 🐛 (folders.spec.ts): increase timeout for page.waitForTimeout to 5000ms and add a comment suggesting to consider using a more reliable waiting mechanism. Also, add a comment to wait for the target element to be available before evaluation. --------- Co-authored-by: Gabriel Luiz Freitas Almeida <gabriel@langflow.org> (cherry picked from commit 4b9dc47)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new test for the recently implemented Freeze Path feature and enhances the existing tests to ensure reliability and accuracy. The improvements to the existing tests include updating the components on the screen before executing the tests, ensuring that the test environment is always in the correct state.
📝 (floatComponent/index.tsx): Add data-testid attribute to float input for testing purposes
🐛 (end-to-end tests): Update test selectors to match changes in component names for consistency and accuracy
✨ (freeze-path.spec.ts): Add end-to-end test for user ability to freeze a path in the application
🐛 (generalBugs-shard-0.spec.ts): Fix outdated component selector in end-to-end test for clearing chat messages
🐛 (generalBugs-shard-1.spec.ts): Fix outdated component selector in end-to-end test for deleting rows from a table message
🐛 (generalBugs-shard-3.spec.ts): Fix outdated component issue by updating the selector for the AlertTriangle icon and the API key input field, and selecting a different model option
🐛 (logs.spec.ts): Fix outdated component issue by updating the selector for the AlertTriangle icon and the API key input field, and selecting a different model option. Also, ensure the "built successfully" text is clicked within a specified timeout
🐛 (textInputOutput.spec.ts): Fix outdated component issue by updating the selector for the AlertTriangle icon and the API key input field, and selecting a different model option