Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Improve caching logic and add disk caching option #3246

Merged
merged 11 commits into from
Aug 9, 2024

Conversation

ogabrielluiz
Copy link
Contributor

This pull request includes several commits that improve the caching logic in the codebase. The Graph class now handles exceptions and cache updates more reliably. The ResultData class has been updated to use key-value pairs in the outputs dictionary for better readability. The get_requester_result method in the Vertex class now uses async await for proper asynchronous handling. Additionally, the cache_type setting has been restricted to specific literals for enhanced type safety and clarity. The pull request also introduces a new AsyncDiskCache class and adds the diskcache package version 5.6.3 to the project dependencies for improved disk-based caching functionality.

@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. enhancement New feature or request labels Aug 8, 2024
Copy link
Contributor

github-actions bot commented Aug 8, 2024

Pull Request Validation Report

This comment is automatically generated by Conventional PR

Whitelist Report

Whitelist Active Result
Pull request is a draft and should be ignored
Pull request is made by a whitelisted user and should be ignored
Pull request is submitted by a bot and should be ignored
Pull request is submitted by administrators and should be ignored

Result

Pull request does not satisfy any enabled whitelist criteria. Pull request will be validated.

Validation Report

Validation Active Result
All commits in this pull request has valid messages
Pull request does not introduce too many changes
Pull request has a valid title
Pull request has mentioned issues
Pull request has valid branch name
Pull request should have a non-empty body

Result

Pull request satisfies all enabled pull request rules.

Last Modified at 08 Aug 24 18:03 UTC

@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request labels Aug 8, 2024
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-3246.dmtpw4p5recq1.amplifyapp.com

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Aug 8, 2024
@ogabrielluiz ogabrielluiz enabled auto-merge (squash) August 9, 2024 12:18
@ogabrielluiz ogabrielluiz merged commit 56ecb18 into main Aug 9, 2024
51 checks passed
@ogabrielluiz ogabrielluiz deleted the feat/diskcache branch August 9, 2024 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants