Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct indentation issue in PythonCodeStructuredTool and correct type for int and float inputs when updating custom component #3323

Merged
merged 20 commits into from
Aug 20, 2024

Conversation

goliath-yamon
Copy link
Contributor

No description provided.

@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. bug Something isn't working python Pull requests that update Python code labels Aug 14, 2024
Copy link
Contributor

Pull Request Validation Report

This comment is automatically generated by Conventional PR

Whitelist Report

Whitelist Active Result
Pull request is a draft and should be ignored
Pull request is made by a whitelisted user and should be ignored
Pull request is submitted by a bot and should be ignored
Pull request is submitted by administrators and should be ignored

Result

Pull request does not satisfy any enabled whitelist criteria. Pull request will be validated.

Validation Report

Validation Active Result
All commits in this pull request has valid messages
Pull request does not introduce too many changes
Pull request has a valid title
Pull request has mentioned issues
Pull request has valid branch name
Pull request should have a non-empty body

Result

Pull request is invalid.

Reason

  • Pull request must have a non-empty body

Last Modified at 14 Aug 24 06:41 UTC

Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-3323.dmtpw4p5recq1.amplifyapp.com

@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. and removed size:S This PR changes 10-29 lines, ignoring generated files. labels Aug 14, 2024
Copy link
Contributor

@ogabrielluiz ogabrielluiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again, @goliath-yamon

Comment on lines 595 to 603
key: value_dict.get("value")
if value_dict.get("_input_type") != "IntInput"
else (
int(value_dict.get("value"))
if value_dict.get("_input_type") != "FloatInput"
else float(value_dict.get("value"))
)
for key, value_dict in template.items()
if isinstance(value_dict, dict)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe something like this would be better

Suggested change
key: value_dict.get("value")
if value_dict.get("_input_type") != "IntInput"
else (
int(value_dict.get("value"))
if value_dict.get("_input_type") != "FloatInput"
else float(value_dict.get("value"))
)
for key, value_dict in template.items()
if isinstance(value_dict, dict)
# Define a mapping of input types to their conversion functions
type_converters = {
"IntInput": int,
"FloatInput": float,
}
# Generate the params dictionary
params = {
key: type_converters.get(value_dict.get("_input_type"), lambda x: x)(value_dict.get("value"))
for key, value_dict in template.items()
if isinstance(value_dict, dict)
}

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Aug 20, 2024
@ogabrielluiz ogabrielluiz enabled auto-merge (squash) August 20, 2024 11:26
@ogabrielluiz ogabrielluiz merged commit de96aee into langflow-ai:main Aug 20, 2024
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working lgtm This PR has been approved by a maintainer python Pull requests that update Python code size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants