Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Update project name retrieval in LCModelComponent and CustomComponent #3506

Merged
merged 1 commit into from
Aug 22, 2024

Conversation

ogabrielluiz
Copy link
Contributor

Return the project name using get_project_name method in both classes.

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Aug 22, 2024
@dosubot dosubot bot added the enhancement New feature or request label Aug 22, 2024
@ogabrielluiz ogabrielluiz force-pushed the refactor-add-a-method-to-get-project_name branch from f2a9ba5 to 4b16bfc Compare August 22, 2024 16:20
Copy link
Contributor

Pull Request Validation Report

This comment is automatically generated by Conventional PR

Whitelist Report

Whitelist Active Result
Pull request is a draft and should be ignored
Pull request is made by a whitelisted user and should be ignored
Pull request is submitted by a bot and should be ignored
Pull request is submitted by administrators and should be ignored

Result

Pull request does not satisfy any enabled whitelist criteria. Pull request will be validated.

Validation Report

Validation Active Result
All commits in this pull request has valid messages
Pull request does not introduce too many changes
Pull request has a valid title
Pull request has mentioned issues
Pull request has valid branch name
Pull request should have a non-empty body

Result

Pull request satisfies all enabled pull request rules.

Last Modified at 22 Aug 24 16:21 UTC

@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request labels Aug 22, 2024
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-3506.dmtpw4p5recq1.amplifyapp.com

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Aug 22, 2024
@ogabrielluiz ogabrielluiz enabled auto-merge (squash) August 22, 2024 17:18
@ogabrielluiz ogabrielluiz force-pushed the refactor-add-a-method-to-get-project_name branch 2 times, most recently from d9e852e to 213ab69 Compare August 22, 2024 18:04
…ponent

Return the project name using get_project_name method in both classes.
@ogabrielluiz ogabrielluiz force-pushed the refactor-add-a-method-to-get-project_name branch from 213ab69 to 85f7374 Compare August 22, 2024 18:50
@ogabrielluiz ogabrielluiz merged commit a98e07e into main Aug 22, 2024
28 checks passed
@ogabrielluiz ogabrielluiz deleted the refactor-add-a-method-to-get-project_name branch August 22, 2024 19:13
anovazzi1 pushed a commit that referenced this pull request Aug 26, 2024
…ponent (#3506)

Return the project name using get_project_name method in both classes.
ogabrielluiz added a commit that referenced this pull request Aug 27, 2024
…ponent (#3506)

Return the project name using get_project_name method in both classes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants