fix: connection_string_parser.py #3522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
size:XS
Pull Request Validation ReportThis comment is automatically generated by Conventional PR Whitelist Report
Result Pull request does not satisfy any enabled whitelist criteria. Pull request will be validated. Validation Report
Result Pull request satisfies all enabled pull request rules. Last Modified at 23 Aug 24 05:18 UTC |
github-actions
bot
added
bug
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
tkdguq05
commented
Aug 23, 2024
In version 1.0.14, a connection string that includes a port, like the following example, works without any issues: `test_connection_string = 'postgresql://postgres:password!!@pgdatabase.hosts:5432'` However, in version 1.0.15, using this connection string causes an error. "Error building Component PGVector: invalid literal for int() with base 10" This is because 5432, which is the result of parsing the password_url, is being used as the last element in the password_url list.
fix
transformed_connection_string = f'{protocol_user}:{encoded_password}@{db_url_name}'
ogabrielluiz
force-pushed
the
tkdguq05/fix_transform_connection_string
branch
from
c22457d
to
61eb59b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In version 1.0.14, a connection string that includes a port, like the following example, works without any issues:
test_connection_string = 'postgresql://postgres:password!!@pgdatabase.hosts:5432'However, in version 1.0.15, using this connection string causes an error.
"Error building Component PGVector: invalid literal for int() with base 10"
This is because "5432", which is the result of parsing the password_url, is being used as the last element in the password_url list.