feature: Add scroll detection for NodeDescription overflow and remove feature flag #3676
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
size:M
anovazzi1
requested review from
vasconceloscezar
and removed request for
vasconceloscezar
dosubot
bot
added
size:L
anovazzi1
changed the title
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
ogabrielluiz
approved these changes
Sep 6, 2024
- Update ENABLE_MVPS flag to false in feature-flags.ts - Update testId from "extended-disclosure" to "bundle-extended-disclosure" in extraSidebarComponent/index.tsx
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds scroll detection for the NodeDescription component. It introduces a useRef hook to create a reference to the overflow div and a useState hook to track whether the div has scroll. The useEffect hook is used to check if the div has scroll after the component updates. If the div has scroll, the "nowheel" class is added to the component. This change improves the user experience by hiding the scroll bar when it is not needed.