Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(YahooFinanceTool): enhance tool with new inputs for data retrieval methods #3738

Merged
merged 6 commits into from
Oct 3, 2024

Conversation

namastex888
Copy link
Contributor

Refactored YF Tool to use the lib directly, rather than langchain's broken implementation. more features were added too.

@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. enhancement New feature or request labels Sep 9, 2024
@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request labels Sep 9, 2024
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-3738.dmtpw4p5recq1.amplifyapp.com

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Sep 9, 2024
@italojohnny italojohnny enabled auto-merge (squash) September 9, 2024 23:07
@italojohnny italojohnny self-requested a review September 10, 2024 18:14
@@ -14,7 +14,7 @@ def complex_agent_graph():
llm = OpenAIModelComponent(model_name="gpt-4o-mini")
manager_llm = OpenAIModelComponent(model_name="gpt-4o")
search_api_tool = SearchAPIComponent()
yahoo_search_tool = YfinanceToolComponent()
Copy link
Contributor

@ogabrielluiz ogabrielluiz Sep 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this instantiation is required. I'm not sure why it was removed

@ogabrielluiz ogabrielluiz merged commit 1128365 into main Oct 3, 2024
29 checks passed
@ogabrielluiz ogabrielluiz deleted the fix-yf-tool branch October 3, 2024 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants