Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add duckduckgo search component #3798

Merged
merged 20 commits into from
Sep 17, 2024
Merged

feat: add duckduckgo search component #3798

merged 20 commits into from
Sep 17, 2024

Conversation

Cristhianzl
Copy link
Collaborator

This pull request introduces a new sidebar component that integrates DuckDuckGo's instant search functionality. This tool allows users to perform quick searches directly within the app without requiring an API key.

  • Instant Search: Users can make fast, direct searches powered by DuckDuckGo.

  • No API Key Required: Streamlines the search process by removing the need for external API keys.

  • Improved User Experience: Adds a convenient, accessible search option directly in the sidebar.

✨ (DuckDuckGoSearchRun.py): introduce DuckDuckGoSearchComponent for performing web searches using DuckDuckGo search engine
✨ (DuckDuckGo.jsx): add SVG icon for DuckDuckGo
✨ (index.tsx): create DuckDuckGoIcon component for displaying DuckDuckGo icon
🔧 (styleUtils.ts): import DuckDuckGoIcon for nodeIconsLucide in styleUtils
@Cristhianzl Cristhianzl self-assigned this Sep 13, 2024
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. enhancement New feature or request labels Sep 13, 2024
@github-actions github-actions bot removed the enhancement New feature or request label Sep 13, 2024
Copy link
Contributor

Detected 2 changes to dependencies in Poetry lockfile

Added duckduckgo-search (6.2.11)
Added primp (0.6.1)

(2 added, 0 removed, 0 updated, 481 not changed)

@github-actions github-actions bot added the enhancement New feature or request label Sep 13, 2024
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-3798.dmtpw4p5recq1.amplifyapp.com

Cristhianzl and others added 7 commits September 13, 2024 15:53
…onent for rate-limited requests

📝 (DuckDuckGoSearchRun.py): Update component description to reflect the addition of retry logic
📝 (DuckDuckGoSearchRun.py): Add new inputs for max_retries and initial_delay to configure retry behavior
📝 (DuckDuckGoSearchRun.py): Update search_response method to use search_with_retry method with retry logic
📝 (DuckDuckGoSearchRun.py): Update format_results method to handle formatted results
📝 (DuckDuckGoSearchRun.py): Add search_with_retry method to handle search with retry logic
📝 (DuckDuckGoSearchRun.py): Update search_response method to use search_with_retry method
📝 (DuckDuckGoSearchRun.py): Update search_response method to set status messages
📝 (DuckDuckGoSearchRun.py): Handle exceptions and set appropriate status messages in search_response method
✨ (duckduckgo.spec.ts): Add integration test for DuckDuckGo search component in frontend
…low best practices and avoid potential issues with some tools that expect it
… pydantic BaseModel for schema definition and improve code structure for better readability and maintainability. Add support for result limiting in search functionality.
@Cristhianzl Cristhianzl requested review from ogabrielluiz and removed request for anovazzi1 September 16, 2024 16:44
Copy link
Contributor

@ogabrielluiz ogabrielluiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Sep 17, 2024
@Cristhianzl Cristhianzl enabled auto-merge (squash) September 17, 2024 15:13
… selecting all text was not working correctly on Mac devices. Updated the key combination to use the correct modifier key based on the user's operating system.
@Cristhianzl Cristhianzl merged commit 8c8be15 into main Sep 17, 2024
29 of 33 checks passed
@Cristhianzl Cristhianzl deleted the cz/duckduckgo branch September 17, 2024 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants