feat: improve CLI parameter handling and cleanup unused code #4002
Conversation
CLI > specific env_file > default env_file
dosubot
bot
added
size:L
github-actions
bot
added
enhancement
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
|
...reviewing the unit tests |
| workers: int = typer.Option(1, help="Number of worker processes.", envvar="LANGFLOW_WORKERS"), | ||
| timeout: int = typer.Option(300, help="Worker timeout in seconds.", envvar="LANGFLOW_WORKER_TIMEOUT"), | ||
| port: int = typer.Option(7860, help="Port to listen on.", envvar="LANGFLOW_PORT"), | ||
| host: str | None = typer.Option(None, help="Host to bind the server to.", show_default=False), |
There was a problem hiding this comment.
Not related to this PR but it would probably be nice to use the syntax host: Annotated[str | None, typer.Option(None, help="Host to bind the server to.", show_default=False)] = None` for all the params for better type checking.
There was a problem hiding this comment.
I tried applying the suggestion, but the code started breaking. I'll take a closer look at it later.
| components_path: Path | None = typer.Option( | ||
| Path(__file__).parent / "components", | ||
| str(Path(__file__).parent / "components"), |
There was a problem hiding this comment.
Should components_path type be changed to str ?
There was a problem hiding this comment.
Oops... that was a small oversight. It should be Path
italojohnny
force-pushed
the
fix/config-priority-hierarchy
branch
from
35fa03a
to
2d47df2
Compare
This PR refines CLI parameter handling, adds default path values, enforces parameter hierarchy, and removes unused code for improved maintainability.
Fixes #3820