ref: Add ruff rules for Pathlib (PTH) #4035
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:L
cbornet
commented
Oct 6, 2024
| @@ -53,7 +55,7 @@ def build_vector_store(self) -> Redis: | |||
| documents.append(_input.to_lc_document()) | |||
| else: | |||
| documents.append(_input) | |||
| with open("docuemnts.txt", "w") as f: | |||
| with Path("docuemnts.txt").open("w") as f: | |||
There was a problem hiding this comment.
typo in file name but I'm not sure of the impact if we change it...
There was a problem hiding this comment.
It seems like this is not being used anywhere
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
cbornet
force-pushed
the
ruff-rules-pth
branch
3 times, most recently
from
7c24564
to
ab032a0
Compare
cbornet
changed the title
cbornet
force-pushed
the
ruff-rules-pth
branch
from
ab032a0
to
19452ce
Compare
cbornet
force-pushed
the
ruff-rules-pth
branch
from
19452ce
to
f821c98
Compare
jordanrfrazier
pushed a commit
that referenced
this pull request
Oct 7, 2024
Add ruff rules for Pathlib (PTH)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add ruff rules for Pathlib (PTH)