fix: exception locations in component classes #4087
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:L
jordanrfrazier
commented
Oct 9, 2024
phact
approved these changes
Oct 9, 2024
jordanrfrazier
force-pushed
the
update-exception-handling-for-ruff
branch
from
992109e
to
a8b296b
Compare
jordanrfrazier
force-pushed
the
update-exception-handling-for-ruff
branch
from
3c57dc9
to
dde6c14
Compare
dosubot
bot
added
size:M
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Component classes parse code unintuitively - the Component class must be the first class in the file. This PR removes the custom exceptions completely, since the error handling wasn't doing anything particular besides re-logging them.
I left the
TRY002ruff rule in place, as it is not an auto-fix; these errors must be manually done, so future devs running into them shouldn't (automatically, at least) fall into the same issue.