ref: Add ruff rules TRY3xx #4098
Open
+678
−567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
size:XXL
cbornet
force-pushed
the
ruff-rules-try3
branch
from
64a77e7
to
f82c962
Compare
cbornet
commented
Oct 10, 2024
| # This means the Flow ID is not a valid UUID which means it can't find the flow | ||
| raise HTTPException(status_code=status.HTTP_404_NOT_FOUND, detail=str(exc)) from exc | ||
| logger.exception(exc) | ||
| raise HTTPException(status_code=status.HTTP_500_INTERNAL_SERVER_ERROR, detail=str(exc)) from exc |
There was a problem hiding this comment.
It seems this exception was missing in StatementError's handling
cbornet
commented
Oct 10, 2024
| except Exception as e: | ||
| if "No result found" in str(e): | ||
| raise HTTPException(status_code=404, detail="Folder not found") from e | ||
| raise HTTPException(status_code=500, detail=str(e)) from e | ||
|
|
||
| if not folder: |
There was a problem hiding this comment.
It seems this was missing
cbornet
commented
Oct 10, 2024
| @@ -203,12 +214,17 @@ async def download_file( | |||
| ): | |||
| """Download all flows from folder.""" | |||
| try: | |||
| return session.exec(select(Folder).where(Folder.id == folder_id, Folder.user_id == current_user.id)).first() | |||
| folder = session.exec(select(Folder).where(Folder.id == folder_id, Folder.user_id == current_user.id)).first() | |||
| except Exception as e: | |||
| if "No result found" in str(e): | |||
There was a problem hiding this comment.
Not sure how this can happen...
ogabrielluiz
approved these changes
Oct 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add ruff rules TRY3xx
TRY301 issues are fixed but not enforcing them atm as they are a bit hard to grok.