Skip to content

Commit

Permalink
Remove protobuf version limit (#712)
Browse files Browse the repository at this point in the history
* remove protobuf version limit
  • Loading branch information
lanpa authored Jul 30, 2023
1 parent c015fea commit b7de4b2
Show file tree
Hide file tree
Showing 3 changed files with 21 additions and 3 deletions.
18 changes: 18 additions & 0 deletions .github/workflows/python-app.yml
Original file line number Diff line number Diff line change
Expand Up @@ -65,3 +65,21 @@ jobs:
python examples/demo_purge.py
python examples/demo_matplotlib.py
test-protobuf-versions:
needs: build
runs-on: ubuntu-latest
strategy:
matrix:
protobuf-version: ["3.20", "4.21", "4.22", "4.23"]
steps:
- uses: actions/checkout@v2
- name: Set up Python 3.11
uses: actions/setup-python@v2
with:
python-version: 3.11
- name: Run examples
run: |
pip install numpy protobuf==${{ matrix.protobuf-version }}
python -c "import tensorboardX"
2 changes: 1 addition & 1 deletion setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ def run(self):
requirements = [
'numpy',
'packaging',
'protobuf>=4.22.3',
'protobuf',
]


Expand Down
4 changes: 2 additions & 2 deletions tensorboardX/beholder/beholder.py
Original file line number Diff line number Diff line change
Expand Up @@ -28,9 +28,9 @@

# from tensorboard.plugins.beholder import im_util
# from . import im_util
from .file_system_tools import read_pickle,\
from .file_system_tools import read_pickle, \
write_pickle, write_file
from .shared_config import PLUGIN_NAME, TAG_NAME,\
from .shared_config import PLUGIN_NAME, TAG_NAME, \
SUMMARY_FILENAME, DEFAULT_CONFIG, CONFIG_FILENAME, SUMMARY_COLLECTION_KEY_NAME, SECTION_INFO_FILENAME
from . import video_writing
# from .visualizer import Visualizer
Expand Down

0 comments on commit b7de4b2

Please sign in to comment.