Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use tempfile for temporary directory in tests. #708

Merged
merged 1 commit into from
Jul 16, 2023
Merged

Use tempfile for temporary directory in tests. #708

merged 1 commit into from
Jul 16, 2023

Conversation

tjni
Copy link
Contributor

@tjni tjni commented Jul 12, 2023

This lets builders control the base directory for temporary files, such as by using the TMPDIR environment variable.

@tjni tjni changed the title Use tmp_path from pytest for temporary directory. Use tempfile for temporary directory in tests. Jul 12, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jul 12, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.04 🎉

Comparison is base (d75a89b) 84.75% compared to head (b0191d1) 84.79%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #708      +/-   ##
==========================================
+ Coverage   84.75%   84.79%   +0.04%     
==========================================
  Files          36       36              
  Lines        2105     2105              
==========================================
+ Hits         1784     1785       +1     
+ Misses        321      320       -1     

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@lanpa
Copy link
Owner

lanpa commented Jul 16, 2023

Thanks!

@lanpa lanpa merged commit c015fea into lanpa:master Jul 16, 2023
5 checks passed
@tjni tjni deleted the respect-system-tempdir branch July 16, 2023 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants