Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.x] Only support MariaDB 11 #707

Merged
merged 1 commit into from
Jul 22, 2024
Merged

[1.x] Only support MariaDB 11 #707

merged 1 commit into from
Jul 22, 2024

Conversation

Jubeki
Copy link
Contributor

@Jubeki Jubeki commented Jul 22, 2024

Reverts #698 and #703 to only one supported MariaDB Version.

Laravel Sail only supports one MySQL version (MySQL 8). The problems which arise with multiple versions of MariaDB, introduce unneeded complexity.

Therefor this PR reverts back to only on supported MariaDB Version, which is now MariaDB 11 instead of MariaDB 10, which it was before the other PRs.

See Issues: #702 and #701

After this is merged and released, I will also revert the changes in the Laravel Sail Server Script: laravel/sail-server#24

How to test the changes:

laravel new sail-test --no-interaction
cd sail-test
composer config repositories.sail vcs https://github.com/Jubeki/laravel-sail.git
composer require laravel/sail:dev-mariadb11 --dev
php artisan sail:install --with=mariadb

vendor/bin/sail up -d --wait
vendor/bin/sail artisan migrate
open http://localhost

Please don't forget to stop the docker container after testing:

vendor/bin/sail down

Copy link

Thanks for submitting a PR!

Note that draft PR's are not reviewed. If you would like a review, please mark your pull request as ready for review in the GitHub user interface.

Pull requests that are abandoned in draft may be closed due to inactivity.

@Jubeki Jubeki marked this pull request as ready for review July 22, 2024 12:22
@Jubeki
Copy link
Contributor Author

Jubeki commented Jul 22, 2024

Seems the problem was my local setup, now no database creation errors happen anymore on my side.

@taylorotwell taylorotwell merged commit 0adb232 into laravel:1.x Jul 22, 2024
5 checks passed
@Jubeki Jubeki deleted the mariadb11 branch July 22, 2024 14:42
@Jubeki Jubeki mentioned this pull request Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants