fix: Sail share 504 timeout fix for linux hosts #709
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Need community confirmation from other users on other operating systems before I can merge. |
|
same problem, fixed for me |
|
Fixes the issue for me |
|
It continues to work on macOS. Does it work on Windows? Right now there is only Feedback from Linux Users as far as I can see. After a Windows user has confirmed, that it works with these changes. The PR should be marked as ready for review, so that Taylor takes a look at this again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #708
I'm aware of the lack of tests here. Perhaps put a pin on this before merging, but this is an entire, pretty awesome feature that is broken for linux users so I think it is at least something to be aware of.