Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setup.cfg: Replace deprecated license_file with license_files #1209

Merged
merged 1 commit into from
Nov 2, 2022

Conversation

mgorny
Copy link
Contributor

@mgorny mgorny commented Nov 2, 2022

Replace the deprecated license_file key with license_files. The latter has the same semantics and is available since setuptools 42.0.0 (that lark already requires).

Replace the deprecated `license_file` key with `license_files`.
The latter has the same semantics and is available since setuptools
42.0.0 (that lark already requires).
@erezsh
Copy link
Member

erezsh commented Nov 2, 2022

Is there a reason to change this? Is license_file ever going to get dropped?

@mgorny
Copy link
Contributor Author

mgorny commented Nov 2, 2022

Is there a reason to change this?

Right now it triggers verbose deprecation warnings that trigger our QA pipelines.

Is license_file ever going to get dropped?

Hard to tell. I've asked setuptools a more general question about timeline for dropping deprecated stuff, and got no answer. However, they definitely did remove some deprecated stuff in the past.

@erezsh erezsh merged commit 7ef5c98 into lark-parser:master Nov 2, 2022
@erezsh
Copy link
Member

erezsh commented Nov 2, 2022

verbose deprecation warnings

Fair enough.

@mgorny mgorny deleted the licfiles branch November 2, 2022 17:24
@mgorny
Copy link
Contributor Author

mgorny commented Nov 2, 2022

Thanks for bearing with me. This is really appreciated.

@erezsh
Copy link
Member

erezsh commented Nov 2, 2022

No problem, thanks for making Lark a tiny bit better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants