Updated Python grammar list literal to support [*x]
#1232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previous version used `_testlist_comp` which allowed for either one `test` or 2 and more `test_or_star_expr` This version allows a list with one `star_expr` which is valid both in Python and in official Python grammar. Moreover it merges rules used in set and list (since those terminals differ only in one thing: set literal cannot be empty)
evtn
changed the title
[*x][*x]
MegaIng
approved these changes
Dec 18, 2022
|
Well, there is a suite that is used by PyPy, which is MIT-licensed and probably will be a good place to start I probably could spend some time on this, since my current project requires a fully working Python grammar anyways |
|
Thank you, @evtn ! If you would like to set up tests for the Python grammar, we'll be happy to include them in our test suite! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous version used
_testlist_compwhich allowed for either onetestor 2 and moretest_or_star_expr.This version also allows a list with one
star_exprwhich is valid both in Python and in official Python grammar.Moreover it merges rules used in
setandlist(since those terminals differ only in that set literal cannot be empty)