Enable Dynamic Enabling / Disabling without External Feature Detection

[asos-dominicjomaa]

Detail

The library before any manual enabling performs a feature detection to check whether the webkit like scroll behaviour property even works, effectively checking if the library will be used at all or not:

var testDiv = document.createElement('div');
document.documentElement.appendChild(testDiv);
testDiv.style.WebkitOverflowScrolling = 'touch';
var isScrollSupported = 'getComputedStyle' in window && window.getComputedStyle(testDiv)['-webkit-overflow-scrolling'] === 'touch';
document.documentElement.removeChild(testDiv);

This works well for situations where you only need this enabled once, but in our use case we need to be able to disable or enable iNoBounce only when a particular overlay is opened, which means this feature detection on the libraries IIFE construction is ignored. This coupled with the 0.1.6 version of the library seems to break Android scrolling entirely. The change here is to expose a boolean that can be rechecked when ever the consumer wishes to enable / disable the iNoBounce behaviour without worrying it will affect non-ios like devices.

As an example this might be used like this:

[SHOW_FILTER_OVERLAY]: state => {
    if (iNoBounce.isScrollSupported) {
      iNoBounce.enable();
    }

    return { ...state, isFilterOverlayVisible: true };
},
[HIDE_FILTER_OVERLAY]: state => {
    if (iNoBounce.isScrollSupported) {
      iNoBounce.disable();
    }

   return { ...state, isFilterOverlayVisible: false };
},

[asos-dominicjomaa]

@lazd would love your thoughts on this!

[Eth-a-n]

This will super handy, looks great !

[lazd]

LGTM, thanks!

[lazd]

Released in 0.2.1!

[asos-dominicjomaa]

@lazd amazing turn around, thanks for the approval!