Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modified the text content and the image in the Related Resources Help Modal #4524

Merged

Conversation

shivansh-bhatnagar18
Copy link
Contributor

@shivansh-bhatnagar18 shivansh-bhatnagar18 commented Apr 19, 2024

Summary

Description of the change(s) you made

As instructed in the issue #4511 , I have made changes in the text of the dialog box and changed the image to the provided image

Manual verification steps performed

  1. Step 1 ) Made the changes and ran the development server locally to see if those work or no

Screenshots (if applicable)

Screenshot from 2024-04-19 17-39-14

PR process:

  • If this is an important user-facing change, PR or related issue the CHANGELOG label been added to this PR. Note: items with this label will be added to the CHANGELOG at a later time
  • If this includes an internal dependency change, a link to the diff is provided
  • The docs label has been added if this introduces a change that needs to be updated in the user docs?
  • If any Python requirements have changed, the updated requirements.txt files also included in this PR
  • Opportunities for using Google Analytics here are noted
  • Migrations are safe for a large db

Studio-specifc:

  • All user-facing strings are translated properly
  • The notranslate class been added to elements that shouldn't be translated by Google Chrome's automatic translation feature (e.g. icons, user-generated text)
  • All UI components are LTR and RTL compliant
  • Views are organized into pages, components, and layouts directories as described in the docs
  • Users' storage used is recalculated properly on any changes to main tree files
  • If there new ways this uses user data that needs to be factored into our Privacy Policy, it has been noted.

Testing:

  • Code is clean and well-commented
  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Any new interactions have been added to the QA Sheet
  • Critical and brittle code paths are covered by unit tests

Reviewer's Checklist

This section is for reviewers to fill out.

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

Copy link
Member

@AlexVelezLl AlexVelezLl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! @ShivangRawat30, looks like the ccorrerct change to me. Just noted one little thing, after that, this should be good to go :).

<VLayout mt-3>
<VFlex>
<!-- <VFlex>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can just remove this code

@shivansh-bhatnagar18
Copy link
Contributor Author

@AlexVelezLl Can you please review the pull request as I have removed the irrelevant code which I commented out earlier. Thanks

@AlexVelezLl AlexVelezLl self-assigned this Apr 24, 2024
Copy link
Member

@AlexVelezLl AlexVelezLl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution @ShivangRawat30! 👐. LGTM 🚀.

@AlexVelezLl AlexVelezLl merged commit 69c8239 into learningequality:unstable Apr 24, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants