Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix save edit completion modal on exercise resources #4660

Merged

Conversation

AlexVelezLl
Copy link
Member

Summary

Description of the change(s) you made

Fix save edit completion modal on exercise resources. MasteryCriteriaMofNFields was being validated even if we didnt need them.

Manual verification steps performed

  1. Verified that edit completion modal was working with all completion types.
  2. Verified that edit all details moadl was still working fine.

Screenshots (if applicable)

Compartir.pantalla.-.2024-08-19.19_05_54.mp4

Reviewer guidance

How can a reviewer test these changes?

Follow instructions in #4648.

Are there any risky areas that deserve extra testing?

Test that edit all details doesnt break.

References

Closes #4648.


Contributor's Checklist

PR process:

  • If this is an important user-facing change, PR or related issue the CHANGELOG label been added to this PR. Note: items with this label will be added to the CHANGELOG at a later time
  • If this includes an internal dependency change, a link to the diff is provided
  • The docs label has been added if this introduces a change that needs to be updated in the user docs?
  • If any Python requirements have changed, the updated requirements.txt files also included in this PR
  • Opportunities for using Google Analytics here are noted
  • Migrations are safe for a large db

Studio-specifc:

  • All user-facing strings are translated properly
  • The notranslate class been added to elements that shouldn't be translated by Google Chrome's automatic translation feature (e.g. icons, user-generated text)
  • All UI components are LTR and RTL compliant
  • Views are organized into pages, components, and layouts directories as described in the docs
  • Users' storage used is recalculated properly on any changes to main tree files
  • If there new ways this uses user data that needs to be factored into our Privacy Policy, it has been noted.

Testing:

  • Code is clean and well-commented
  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Any new interactions have been added to the QA Sheet
  • Critical and brittle code paths are covered by unit tests

Reviewer's Checklist

This section is for reviewers to fill out.

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

Copy link
Member

@rtibbles rtibbles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes make sense, manual verification checks out.

@rtibbles rtibbles merged commit 9f40dab into learningequality:unstable Aug 20, 2024
13 checks passed
@AlexVelezLl AlexVelezLl deleted the fix-comopletion-modal branch August 20, 2024 17:52
@pcenov
Copy link
Member

pcenov commented Aug 21, 2024

Thanks @AlexVelezLl - I confirm that the issue described in #4648 is fixed now. cc @radinamatic

@akolson akolson mentioned this pull request Aug 24, 2024
@akolson akolson mentioned this pull request Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unstable - Edit completion modal for an exercise - Cannot save most of the completion types
3 participants