Support for PhotoMaker Version 2 #358
Open
+851
−57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 11 commits
August 15, 2024 21:06
… done by a manual step and pass as an input file
…strides need to be recalculated or set properly; still failing at soft_max cuda op
|
Thank you for your contribution. I'll find some time to review your changes. Can you merge the latest master branch? |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR added support for PhotoMaker V2 (PMV2).
PMV2 requires/adds a face detection step via insightface. I couldn't find a C++ lib to do equivalent in SD. (There is a c++ SDK called InspireFace but it is pretty heavy and I don't think SD wants to add it as dependency). So a workaround is to add an additional manual step: a python script was created to do face detection and generate resultant id_embedding. This id_embedding is then fed into SD along with input images.
See more in updated README.