Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edgeview App needs latest pillar vendor files #3536

Merged
merged 2 commits into from
Oct 28, 2023

Conversation

naiming-zededa
Copy link
Contributor

  • import the latest changes in zedroutertypes.go for app IP display to work
  • fix an issue of single instance JWT file but user specifying instance number > 1

Signed-off-by: Naiming Shen <naiming@zededa.com>
…y name change

Signed-off-by: Naiming Shen <naiming@zededa.com>
@codecov
Copy link

codecov bot commented Oct 26, 2023

Codecov Report

Attention: 798 lines in your changes are missing coverage. Please review.

Comparison is base (0f7bbc4) 20.50% compared to head (a0c645b) 20.51%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3536      +/-   ##
==========================================
+ Coverage   20.50%   20.51%   +0.01%     
==========================================
  Files         208      208              
  Lines       45381    45381              
==========================================
+ Hits         9307     9312       +5     
+ Misses      35392    35387       -5     
  Partials      682      682              
Files Coverage Δ
.../github.com/lf-edge/eve/pkg/pillar/types/errors.go 0.00% <0.00%> (ø)
...m/lf-edge/eve/pkg/pillar/types/cachedresolvedip.go 0.00% <0.00%> (ø)
...ithub.com/lf-edge/eve/pkg/pillar/types/conntest.go 0.00% <0.00%> (ø)
...dor/github.com/lf-edge/eve/pkg/pillar/types/dns.go 36.47% <36.47%> (ø)
...dor/github.com/lf-edge/eve/pkg/pillar/types/dpc.go 9.33% <9.33%> (ø)

... and 11 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@eriknordmark eriknordmark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Is the missing instid > 1 check a regression from earlier? I'm asking to determine whether this is something we should consider backporting to stable releases.

@milan-zededa
Copy link
Contributor

LGTM.

Is the missing instid > 1 check a regression from earlier? I'm asking to determine whether this is something we should consider backporting to stable releases.

I think we should also backport this to 11.0 (if it is going to be stable release). Otherwise app command will not work in that particular version due to underlay renaming.

@naiming-zededa
Copy link
Contributor Author

LGTM.

Is the missing instid > 1 check a regression from earlier? I'm asking to determine whether this is something we should consider backporting to stable releases.

this thing has been there for quite a while. I only saw this issue with debug Andrew's problem starting a tcp session. I don't think this is a big deal.

@naiming-zededa
Copy link
Contributor Author

LGTM.
Is the missing instid > 1 check a regression from earlier? I'm asking to determine whether this is something we should consider backporting to stable releases.

this thing has been there for quite a while. I only saw this issue with debug Andrew's problem starting a tcp session. I don't think this is a big deal.

if needed, sure. May be this is ok, since we'll make the LTS for version 11 later, and that is more people will use.

@eriknordmark eriknordmark merged commit 660a31a into lf-edge:master Oct 28, 2023
24 of 29 checks passed
@naiming-zededa naiming-zededa deleted the naiming-edgeview-app branch October 28, 2023 18:10
@eriknordmark eriknordmark added the stable Should be backported to stable release(s) label Apr 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stable Should be backported to stable release(s)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants