reverted changes to the assets, referenced to the input tag #3725
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: yash-zededa <126680600+yash-zededa@users.noreply.github.com>
uncleDecart
reviewed
Jan 30, 2024
| @@ -47,56 +38,57 @@ jobs: | |||
| # if the default server is responding -- we can skip apt update | |||
| $APT_INSTALL || { sudo apt update && $APT_INSTALL ; } | |||
| echo "ARCH=${{ matrix.arch }}" >> "$GITHUB_ENV" | |||
| echo "TAG=$(git describe --always --tags | grep -E '[0-9]*\.[0-9]*\.[0-9]*' || echo snapshot)" >> "$GITHUB_ENV" | |||
| - name: ensure clean assets dir | |||
There was a problem hiding this comment.
Why keep assets folder?
There was a problem hiding this comment.
I have just reverted to the version of the file from the version https://github.com/lf-edge/eve/blob/0ee051623dcc26176c82ad012a8f29ca35fbbd9f/.github/workflows/assets.yml and tagged an input param reference to be called from the publish.yml file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverted changes to the assets.yml added the reference and workflow call from the publish.yml