Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

yetus: Remove calls to rand.Seed() #3747

Merged
merged 1 commit into from
Feb 7, 2024
Merged

Conversation

eriknordmark
Copy link
Contributor

Fixes: golangcilint: SA1019: rand.Seed has been deprecated since Go 1.20 and an alternative has been available since Go 1.0: As of Go 1.20 there is no reason to call Seed with a random value. Programs that call Seed with a known value to get a specific sequence of results should use New(NewSource(seed)) to obtain a local random generator. (staticcheck)

Fixes: golangcilint: SA1019: rand.Seed has been deprecated since Go 1.20
and an alternative has been available since Go 1.0: As of Go 1.20 there
is no reason to call Seed with a random value. Programs that call Seed
with a known value to get a specific sequence of results should use
New(NewSource(seed)) to obtain a local random generator. (staticcheck)

Signed-off-by: eriknordmark <erik@zededa.com>
Copy link

codecov bot commented Feb 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2dcaf10) 19.69% compared to head (76b57ee) 19.71%.
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3747      +/-   ##
==========================================
+ Coverage   19.69%   19.71%   +0.02%     
==========================================
  Files         235      235              
  Lines       51708    51708              
==========================================
+ Hits        10185    10196      +11     
+ Misses      40782    40773       -9     
+ Partials      741      739       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@deitch
Copy link
Contributor

deitch commented Feb 7, 2024

Eden is running now

@eriknordmark
Copy link
Contributor Author

FWIW the eden user apps test suite failed with
t2_0_m_0 dcee90cc-353a-4876-883b-ebecfca842c1 app: t2 library/nginx:latest CONTAINER 0 B - / IN_CONFIG RESOLVING_TAG: description:"\nSyncer Download Status of image name: library/nginx:latest, location: - error error pulling image ref: GET https://index.docker.io/v2/library/nginx/manifests/sha256:d02f9b9db4d759ef27dc26b426b842ff2fb881c5c6079612d27ec36e36b132dd: TOOMANYREQUESTS: You have reached your pull rate limit. You may increase the limit by authenticating and upgrading: https://www.docker.com/increase-rate-limit" timestamp:{seconds:1707335068 nanos:559033647} severity:SEVERITY_NOTICE retry_condition:"Will retry in 1m0s; have retried 7 times"

@eriknordmark eriknordmark merged commit 7c282b8 into lf-edge:master Feb 7, 2024
27 of 32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants