Make test in pillar container #3804
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christoph-zededa
force-pushed
the
make_test_in_pillar_container
branch
5 times, most recently
from
23423d5
to
1e684c2
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3804 +/- ##
==========================================
- Coverage 20.27% 17.51% -2.76%
==========================================
Files 236 3 -233
Lines 52143 805 -51338
==========================================
- Hits 10570 141 -10429
+ Misses 40809 629 -40180
+ Partials 764 35 -729 ☔ View full report in Codecov by Sentry. |
christoph-zededa
force-pushed
the
make_test_in_pillar_container
branch
from
1e684c2
to
9434be2
Compare
|
Yetus failed yamllint with (I don't know why this was not added as an annotation to the diffs.) |
Instead of running the tests in the builder container, run those in the pillar container. Advantages: - the environment is nearer to the real EVE - packages don't have to be put into pillar and builder container Signed-off-by: Christoph Ostarek <christoph@zededa.com>
christoph-zededa
force-pushed
the
make_test_in_pillar_container
branch
from
9434be2
to
3b50230
Compare
christoph-zededa
force-pushed
the
make_test_in_pillar_container
branch
2 times, most recently
from
de8aa92
to
5a200e3
Compare
a lot of those tests are not unit tests and calling those 'unit tests' is confusing Signed-off-by: Christoph Ostarek <christoph@zededa.com>
christoph-zededa
force-pushed
the
make_test_in_pillar_container
branch
from
5a200e3
to
19c35b0
Compare
rouming
approved these changes
Mar 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makefile: run pillar tests in pillar container
Instead of running the tests in the builder container,
run those in the pillar container.
Advantages: