Do not forget to report error severity #3843
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For network instances, network connectivity testing and IO bundle processing we do not really use different error severity levels at the moment. For any encountered issue we simply report an error message up to zedagent and further to the controller. However, zedagent forgets to set the severity to "error" and leaves it as unspecified. This may have unwanted effect on how the error message is treated/displayed by the controller. Later, we could improve this and use different severity levels also for connectivity testing. For example, longer the port connectivity is down, the more severe the error reported would be. Signed-off-by: Milan Lenco <milan@zededa.com>
milan-zededa
force-pushed
the
specify-err-severity
branch
from
9556acf
to
177f0aa
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3843 +/- ##
=======================================
Coverage 17.51% 17.51%
=======================================
Files 3 3
Lines 805 805
=======================================
Hits 141 141
Misses 629 629
Partials 35 35 ☔ View full report in Codecov by Sentry. |
christoph-zededa
approved these changes
Apr 4, 2024
rouming
approved these changes
Apr 5, 2024
eriknordmark
approved these changes
Apr 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For network instances, network connectivity testing and IO bundle processing we do not really use different error severity levels at the moment. For any encountered issue we simply report an error message up to zedagent and further to the controller. However, zedagent forgets to set the severity to "error" and leaves it as unspecified. This may have unwanted effect on how the error message is treated/displayed by the controller.
Later, we could improve this and use different severity levels also for connectivity testing. For example, longer the port connectivity is down, the more severe the error reported would be (i.e. we do not immediately report failed connectivity test as "error" but start with e.g. "warning").