Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Linux FW and REGDB #3856

Merged
merged 2 commits into from
Apr 19, 2024
Merged

Conversation

rucoder
Copy link
Contributor

@rucoder rucoder commented Apr 15, 2024

NOTE: this PR depends on #3852

Image size impact: negative, we save about 7Mb of space in rootfs

@rucoder rucoder requested a review from rene as a code owner April 15, 2024 19:11
@rucoder rucoder requested review from eriknordmark and removed request for rene April 15, 2024 19:11
@github-actions github-actions bot requested a review from rene April 15, 2024 19:12
@rucoder rucoder requested a review from rouming April 15, 2024 19:12
Copy link
Contributor

@eriknordmark eriknordmark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rucoder
Copy link
Contributor Author

rucoder commented Apr 17, 2024

@eriknordmark I have not updated eve-alpine hash. Do not merge yet

@eriknordmark eriknordmark marked this pull request as draft April 17, 2024 14:09
@eriknordmark
Copy link
Contributor

@eriknordmark I have not updated eve-alpine hash. Do not merge yet

The more robust way to handle such situtations is the mark the PR as a draft, which I just did.

- use 'realname' from coreutils because the one provided by busybox
is not compatible with installation script from Linux FW package

- add rdfind used by installation script

- Remove workaround for brcm FW since the fix is merged upstream

Signed-off-by: Mikhail Malyshev <mike.malyshev@gmail.com>
Just keep regdb up-to-date. We have not updated it for 2 years

Signed-off-by: Mikhail Malyshev <mike.malyshev@gmail.com>
@rucoder rucoder marked this pull request as ready for review April 18, 2024 09:58
@rucoder
Copy link
Contributor Author

rucoder commented Apr 18, 2024

@eriknordmark I have not updated eve-alpine hash. Do not merge yet

The more robust way to handle such situtations is the mark the PR as a draft, which I just did.

I agree, the PR #3852 build failed initially and we had to rerun it and then I had to run to airport. All green now, we can merge

@eriknordmark eriknordmark merged commit 2940e6c into lf-edge:master Apr 19, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants