Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kubevirt: longhorn configuration #3878

Merged

Conversation

andrewd-zededa
Copy link
Contributor

Bump to latest version 1.6.0 including upstream change to find the correct iscsid pid when running k3s in a container. nsmounter replacement to fix PID enabling RWX PVC mounts findutils: needed for -regextype option
nfs-utils: for RWX (nfs) PVCs
longhorn-generate-support-bundle.sh:
request a support bundle containing complete lh logs written to longhornsupportbundle_*.zip in
/persist/newlog/kube/
Lowered iSCSI queue depth to handle large CDI volume uploads. This is temporary until performance testing completes. Set default disk path (pool) to /persist/vault/volumes

Part 2 of the breakup of now-draft PR:#3838

Copy link
Contributor

@eriknordmark eriknordmark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two shellcheck issues. Other than that it looks good to me.

Copy link

codecov bot commented Apr 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 17.51%. Comparing base (d864826) to head (7f6e945).
Report is 60 commits behind head on master.

❗ Current head 7f6e945 differs from pull request most recent head 1f0ef31. Consider uploading reports for the commit 1f0ef31 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3878   +/-   ##
=======================================
  Coverage   17.51%   17.51%           
=======================================
  Files           3        3           
  Lines         805      805           
=======================================
  Hits          141      141           
  Misses        629      629           
  Partials       35       35           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

pkg/kube/longhorn-generate-support-bundle.sh Show resolved Hide resolved
pkg/kube/longhorn-generate-support-bundle.sh Outdated Show resolved Hide resolved
pkg/kube/nsmounter Outdated Show resolved Hide resolved
@andrewd-zededa andrewd-zededa force-pushed the andrewd-kubevirt-longhorn-part2 branch 3 times, most recently from a2b1960 to 526672a Compare April 24, 2024 22:33
Bump to latest version 1.6.0 including upstream change to
find the correct iscsid pid when running k3s in a container.
nsmounter replacement to fix PID enabling RWX PVC mounts
findutils: needed for -regextype option
nfs-utils: for RWX (nfs) PVCs
longhorn-generate-support-bundle.sh:
request a support bundle containing complete lh logs
written to longhornsupportbundle_*.zip in
/persist/newlog/kube/
Temporarily lowered iSCSI queue depth to
handle large CDI volume uploads.
This is temporary until performance testing completes.
Set default disk path (pool) to /persist/vault/volumes

Signed-off-by: Andrew Durbin <andrewd@zededa.com>
@andrewd-zededa andrewd-zededa force-pushed the andrewd-kubevirt-longhorn-part2 branch from 526672a to 1f0ef31 Compare April 24, 2024 23:10
@eriknordmark eriknordmark merged commit 1614e41 into lf-edge:master Apr 25, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants