[12.0 stable candidate] Properly mark DHCP & DNS traffic entering switch NI from outside #3890
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After a recent change that prevents non-app traffic from being forwarded between ports based on the assigned mark, it is important that even implicitly allowed DHCP & DNS traffic entering switch NI from outside is properly marked. However, in our implementation we skipped DHCP & DNS marking rules for ingress direction, assuming that replies would be matched with their requests in the conntrack table and mark would get propagated. With such assumption, we only added DHCP & DNS marking rules for the egress direction (app requests). But apparently, request-reply conntrack matching does not work for DHCP, so let's avoid this assumption altogether and install marking rules for DHCP & DNS for both directions (for switch NI). Signed-off-by: Milan Lenco <milan@zededa.com> (cherry picked from commit f7e3dbf)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #3885 into 12.0 branch (LTS candidate).
Signed-off-by: Milan Lenco milan@zededa.com
(cherry picked from commit f7e3dbf)