-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wwan: Add FCC-unlock tool from Lenovo #3918
Conversation
5f757a8
to
89c54cb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The license at https://github.com/lenovo/lenovo-wwan-unlock/blob/main/Lenovo%20Licence%20Agreement.pdf doesn't read like an OSS license but a generic license which can be used for paid software as well as OSS software. I think we need to work with users which buy Lenovo servers to see if we can get them to provide this software under an OSS-approved license.
Turns out the branch we use (https://github.com/lenovo/lenovo-wwan-unlock/tree/alpine-os-wwan) does not include that pdf file so we're fine. |
@eriknordmark , I don't think we are fine, this branch has no license at all.... since it was delivered for EVE OS, I think we could ask for the inclusion of a license that allows the binaries to be distributed (without modification) under OSS compatible licenses... we have similar licenses for NXP and NVIDIA firmware... |
# Install FCC-unlock scripts/tools provided by device vendors | ||
ADD --keep-git-dir=true https://github.com/lenovo/lenovo-wwan-unlock.git#${LENOVO_WWAN_UNLOCK_COMMIT} /lenovo-wwan-unlock | ||
WORKDIR /lenovo-wwan-unlock | ||
RUN cp libmbimtools.so /out/usr/lib/ && chmod 444 /out/usr/lib/libmbimtools.so |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you need to pack both RUNs into one to make yetus happy...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where do you see this yetus error? results-full.txt
in yetus-scan.zip
is empty even though the yetus check failed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I re-run the action, actually errors were in shellcheck:
pkg/wwan/fcc-unlock/1eac:1002:14:89: note: Note that A && B || C is not if-then-else. C may run when A is true. [SC2015]
pkg/wwan/fcc-unlock/2c7c:030a:14:89: note: Note that A && B || C is not if-then-else. C may run when A is true. [SC2015]
pkg/wwan/fcc-unlock/2c7c:0311:14:89: note: Note that A && B || C is not if-then-else. C may run when A is true. [SC2015]
https://github.com/lf-edge/eve/actions/runs/9082764731/artifacts/1505442469
Check the report.html file...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that A && B || C is not if-then-else. C may run when A is true
But that is exactly how I want it to behave :)
If the Lenovo tool fails, try the open-source solution as a fallback.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Then put in the comment(s) to ignore SC2015
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (but some yetus complaints per @rene )
This tool is able to perform FCC unlock procedure on devices: * ThinkEdge SE30 with modem Quectel EM160 * ThinkEdge SE10 with modem Quectel EM05-G Signed-off-by: Milan Lenco <milan@zededa.com>
89c54cb
to
c276072
Compare
This tool is able to perform FCC unlock procedure on devices: