Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump eve alpine #3928

Merged
merged 1 commit into from
May 27, 2024
Merged

Bump eve alpine #3928

merged 1 commit into from
May 27, 2024

Conversation

christoph-zededa
Copy link
Contributor

No description provided.

@eriknordmark
Copy link
Contributor

Looks like the build has issues of the form:
: /home/ubuntu/actions-runner/_work/eve/eve/dist/amd64/0.0.0-pr3928-dea670a8/installer/EFI: Succeeded
./tools/makeconfig.sh /home/ubuntu/actions-runner/_work/eve/eve/dist/amd64/0.0.0-pr3928-dea670a8/installer/config.img "0.0.0-pr3928-dea670a8" conf/DevicePortConfig conf/grub.cfg.tmpl conf/onboard.cert.pem conf/onboard.key.pem conf/root-certificate.pem conf/server conf/v2tlsbaseroot-certificates.pem
Unable to find image 'lfedge/eve-mkconf:46f3092ae249ee00da2612e368c5e7637922376d' locally
docker: Error response from daemon: manifest for lfedge/eve-mkconf:46f3092ae249ee00da2612e368c5e7637922376d not found: manifest unknown: manifest unknown.

@rene
Copy link
Contributor

rene commented May 22, 2024

Looks like the build has issues of the form: : /home/ubuntu/actions-runner/_work/eve/eve/dist/amd64/0.0.0-pr3928-dea670a8/installer/EFI: Succeeded ./tools/makeconfig.sh /home/ubuntu/actions-runner/_work/eve/eve/dist/amd64/0.0.0-pr3928-dea670a8/installer/config.img "0.0.0-pr3928-dea670a8" conf/DevicePortConfig conf/grub.cfg.tmpl conf/onboard.cert.pem conf/onboard.key.pem conf/root-certificate.pem conf/server conf/v2tlsbaseroot-certificates.pem Unable to find image 'lfedge/eve-mkconf:46f3092ae249ee00da2612e368c5e7637922376d' locally docker: Error response from daemon: manifest for lfedge/eve-mkconf:46f3092ae249ee00da2612e368c5e7637922376d not found: manifest unknown: manifest unknown.

@eriknordmark , it looks like some dependency order problem.... @christoph-zededa , if you move the update of pkg/mkconf/Dockerfile to a separated PR I think this one should work....

rene
rene reviewed May 22, 2024
View reviewed changes
pkg/mkconf/Dockerfile Outdated Show resolved Hide resolved
@github-actions github-actions bot requested a review from rene May 22, 2024 12:43
@rene
Copy link
Contributor

rene commented May 22, 2024

Kicking again the amd64 build...

@rene
Copy link
Contributor

rene commented May 22, 2024

@christoph-zededa , amd64 build is failing because of pkg/uefi and it's not related to the alpine package... you will need to remove it from this PR as well....

https://github.com/lf-edge/eve/actions/runs/9191506107/job/25287301023?pr=3928#step:8:23860

@christoph-zededa
Copy link
Contributor Author

@christoph-zededa , amd64 build is failing because of pkg/uefi and it's not related to the alpine package... you will need to remove it from this PR as well....

https://github.com/lf-edge/eve/actions/runs/9191506107/job/25287301023?pr=3928#step:8:23860

Thank you! Yesterday I've built it locally and everything but the verification image was successful.

@rene
Copy link
Contributor

rene commented May 22, 2024

@christoph-zededa , amd64 build is failing because of pkg/uefi and it's not related to the alpine package... you will need to remove it from this PR as well....
https://github.com/lf-edge/eve/actions/runs/9191506107/job/25287301023?pr=3928#step:8:23860

Thank you! Yesterday I've built it locally and everything but the verification image was successful.

The problem resides on a submodule library from EDK2: https://git.cryptomilk.org/projects/cmocka.git

Their git server seems to be offline:

$ git clone https://git.cryptomilk.org/projects/cmocka.git
Cloning into 'cmocka'...
fatal: unable to access 'https://git.cryptomilk.org/projects/cmocka.git/': The requested URL returned error: 500

Probably it was online yesterday.... maybe it's just a matter of wait them to restart their git server...

@christoph-zededa
Dockerfiles: bump eve-alpine image
98b433e 
Signed-off-by: Christoph Ostarek <christoph@zededa.com>
@christoph-zededa
Copy link
Contributor Author

Probably it was online yesterday.... maybe it's just a matter of wait them to restart their git server...

And now they're back :-)

@eriknordmark
Copy link
Contributor

Build is still having issues when re-running:
: /home/ubuntu/actions-runner/_work/eve/eve/dist/amd64/0.0.0-pr3928-15a982d8/rootfs.tar: Succeeded
: /home/ubuntu/actions-runner/_work/eve/eve/dist/amd64/0.0.0-pr3928-15a982d8/installer/rootfs.img: Begin
./tools/makerootfs.sh imagefromtar -t /home/ubuntu/actions-runner/_work/eve/eve/dist/amd64/0.0.0-pr3928-15a982d8/rootfs.tar -i /home/ubuntu/actions-runner/_work/eve/eve/dist/amd64/0.0.0-pr3928-15a982d8/installer/rootfs.img -f squash -a amd64
Unable to find image 'lfedge/eve-mkrootfs-squash:1c718d751d9f9e57b5e45db7ee07895973c3521f' locally
docker: Error response from daemon: manifest for lfedge/eve-mkrootfs-squash:1c718d751d9f9e57b5e45db7ee07895973c3521f not found: manifest unknown: manifest unknown.

@eriknordmark
Copy link
Contributor

@christoph-zededa did you change something in the force push today? If so we can try re-approving (instead of re-running)

@christoph-zededa
Copy link
Contributor Author

@christoph-zededa did you change something in the force push today? If so we can try re-approving (instead of re-running)

I did, I re-added the update for pkg/uefi as their git server is now reachable again (#3928 (comment) )

@rene rene mentioned this pull request May 23, 2024
Merged
rene
rene approved these changes May 23, 2024
View reviewed changes
Copy link
Contributor

@rene rene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving again to see if it builds as it is now....

@christoph-zededa
Copy link
Contributor Author

https://github.com/lf-edge/eve/actions/runs/9208196058/job/25338125484?pr=3928#step:3:1804

CGO_ENABLED=0 GOOS=linux GOARCH=amd64 go build -ldflags "-s -w" -o dist/bin/eden-linux-amd64 .
/opt/hostedtoolcache/go/1.18.10/x64/pkg/tool/linux_amd64/link: signal: killed

;-(

@eriknordmark eriknordmark merged commit 42cef19 into lf-edge:master May 27, 2024
24 of 32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rene rene rene approved these changes

@milan-zededa milan-zededa Awaiting requested review from milan-zededa milan-zededa is a code owner

@rouming rouming Awaiting requested review from rouming rouming is a code owner

@deitch deitch Awaiting requested review from deitch deitch is a code owner

@zedi-pramodh zedi-pramodh Awaiting requested review from zedi-pramodh zedi-pramodh is a code owner

@eriknordmark eriknordmark Awaiting requested review from eriknordmark eriknordmark is a code owner

@jsfakian jsfakian Awaiting requested review from jsfakian

@naiming-zededa naiming-zededa Awaiting requested review from naiming-zededa

@OhmSpectator OhmSpectator Awaiting requested review from OhmSpectator OhmSpectator is a code owner

@rucoder rucoder Awaiting requested review from rucoder

@shjala shjala Awaiting requested review from shjala

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@christoph-zededa @eriknordmark @rene