Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump remaining eve alpine images #3953

Merged
merged 2 commits into from
Jun 5, 2024

Conversation

christoph-zededa
Copy link
Contributor

No description provided.

@christoph-zededa christoph-zededa changed the title Bump eve alpine2 Bump remaining eve alpine images May 29, 2024
@rucoder
Copy link
Contributor

rucoder commented May 29, 2024

@christoph-zededa could you share a one-liner you use to update eve-alpine SHA?

@christoph-zededa
Copy link
Contributor Author

@christoph-zededa could you share a one-liner you use to update eve-alpine SHA?

It was:

find ./ -name Dockerfile -exec perl -pni.bak -e 's/lfedge\/eve-alpine(\S+)/lfedge\/eve-alpine:1f7685f95a475c6bbe682f0b976f12180b6c8726/' "{}" \;

@christoph-zededa
Copy link
Contributor Author

It builds locally, but not on the pipeline - trying to find out what's the problem here by using trial and error :-(

Copy link

codecov bot commented May 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 17.51%. Comparing base (c2bf448) to head (7d5f891).
Report is 34 commits behind head on master.

Current head 7d5f891 differs from pull request most recent head 90fc103

Please upload reports for the commit 90fc103 to get more accurate results.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3953   +/-   ##
=======================================
  Coverage   17.51%   17.51%           
=======================================
  Files           3        3           
  Lines         805      805           
=======================================
  Hits          141      141           
  Misses        629      629           
  Partials       35       35           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot requested a review from deitch May 29, 2024 14:41
@christoph-zededa christoph-zededa force-pushed the bump_eve-alpine2 branch 3 times, most recently from 9a3025a to febe1a2 Compare May 29, 2024 16:48
@christoph-zededa
Copy link
Contributor Author

I see f.e.:

2024-05-29T17:00:39.1029287Z ++ linuxkit pkg show-tag /home/ubuntu/actions-runner/_work/eve/eve/tools/..//pkg/mkrootfs-squash

and then later:

2024-05-29T17:00:39.1423611Z + docker run -i --rm -v /dev:/dev --privileged -v /home/ubuntu/actions-runner/_work/eve/eve/dist/amd64/0.0.0-pr3953-c8b4fb69/installer/rootfs.img:/rootfs.img lfedge/eve-mkrootfs-squash:1c718d751d9f9e57b5e45db7ee07895973c3521f
2024-05-29T17:00:39.1515004Z Unable to find image 'lfedge/eve-mkrootfs-squash:1c718d751d9f9e57b5e45db7ee07895973c3521f' locally
2024-05-29T17:00:40.3567924Z docker: Error response from daemon: manifest for lfedge/eve-mkrootfs-squash:1c718d751d9f9e57b5e45db7ee07895973c3521f not found: manifest unknown: manifest unknown.

@christoph-zededa christoph-zededa force-pushed the bump_eve-alpine2 branch 2 times, most recently from facc53a to 6f7b94d Compare June 3, 2024 12:22
@christoph-zededa
Copy link
Contributor Author

 eve-build-ubuntu docker container is ready to use
/home/ubuntu/actions-runner/_work/eve/eve/build-tools/bin/linuxkit  cache export --arch amd64 --outfile /tmp/tmp.j9v3x2cN4u  Using
time="2024-06-03T12:19:09Z" level=fatal msg="error getting reader for image Using: error parsing image name: could not parse reference: docker.io/library/Using"

oO

@christoph-zededa christoph-zededa marked this pull request as ready for review June 3, 2024 13:17
@christoph-zededa
Copy link
Contributor Author

Seems to work now, only mkverification image fails as some dependencies in eve-alpine fail, but if I fix that, then I have to bump everything again ...

Makefile Outdated
@@ -811,7 +811,7 @@ $(RUNME) $(BUILD_YML):
cp pkg/eve/$(@F) $@

EVE_ARTIFACTS=$(BIOS_IMG) $(EFI_PART) $(CONFIG_IMG) $(PERSIST_IMG) $(INITRD_IMG) $(INSTALLER_IMG) $(ROOTFS_IMG) $(SBOM) $(BSP_IMX_PART) fullname-rootfs $(BOOT_PART)
eve: $(INSTALLER) $(EVE_ARTIFACTS) current $(RUNME) $(BUILD_YML) | $(BUILD_DIR)
eve: pkgs $(INSTALLER) $(EVE_ARTIFACTS) current $(RUNME) $(BUILD_YML) | $(BUILD_DIR)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I sometimes do make pkg/pillar rootfs eve.
With this change that will rebuild all of pkg/* from source, which will take an hour or so more.
Why do you need to add pkgs as a dependency here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise it fails on the pipeline

But:

  1. It should not take an hour
  2. make -j 8 eve would help a bit
  3. I guess the way to fix it, is changing .github/workflows/build.yml (but let's wait first until eden tests are finished; will do tomorrow)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By "pipeline" you mean our GH workflows? I thought those explictly do make pkgs

Copy link
Contributor Author

@christoph-zededa christoph-zededa Jun 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed the commit and now the pipeline fails with: https://github.com/lf-edge/eve/actions/runs/9364843044/job/25779040231?pr=3953

Unable to find image 'lfedge/eve-mkconf:46f3092ae249ee00da2612e368c5e7637922376d' locally

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed the commit and now the pipeline fails with: https://github.com/lf-edge/eve/actions/runs/9364843044/job/25779040231?pr=3953

Unable to find image 'lfedge/eve-mkconf:46f3092ae249ee00da2612e368c5e7637922376d' locally

Is it only pkg/mkconf which needs to be rebuilt? Or are there others?

Copy link
Contributor Author

@christoph-zededa christoph-zededa Jun 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are more, the next one is:

docker: Error response from daemon: manifest for lfedge/eve-mkrootfs-squash:1c718d751d9f9e57b5e45db7ee07895973c3521f not found: manifest unknown: manifest unknown.

(from https://github.com/lf-edge/eve/actions/runs/9368233114/job/25790219160?pr=3953 )

Unfortunately I cannot reproduce this problem locally (I thought it is this PRUNE=1 but it is a different thing).

Copy link
Contributor

@eriknordmark eriknordmark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kick of tests

@christoph-zededa
Copy link
Contributor Author

toomanyrequests: You have reached your pull rate limit. You may increase the limit by authenticating and upgrading:

:-(

Signed-off-by: Christoph Ostarek <christoph@zededa.com>
some dependencies seem to miss, so do this to fix it

Signed-off-by: Christoph Ostarek <christoph@zededa.com>
Copy link
Contributor

@eriknordmark eriknordmark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eriknordmark eriknordmark merged commit 8c6d34d into lf-edge:master Jun 5, 2024
22 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants