-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump remaining eve alpine images #3953
Bump remaining eve alpine images #3953
Conversation
210cea3
to
5617b5f
Compare
5617b5f
to
3050544
Compare
@christoph-zededa could you share a one-liner you use to update eve-alpine SHA? |
It was:
|
It builds locally, but not on the pipeline - trying to find out what's the problem here by using trial and error :-( |
3050544
to
40e090d
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3953 +/- ##
=======================================
Coverage 17.51% 17.51%
=======================================
Files 3 3
Lines 805 805
=======================================
Hits 141 141
Misses 629 629
Partials 35 35 ☔ View full report in Codecov by Sentry. |
9a3025a
to
febe1a2
Compare
I see f.e.:
and then later:
|
facc53a
to
6f7b94d
Compare
oO |
6f7b94d
to
7d5f891
Compare
Seems to work now, only |
Makefile
Outdated
@@ -811,7 +811,7 @@ $(RUNME) $(BUILD_YML): | |||
cp pkg/eve/$(@F) $@ | |||
|
|||
EVE_ARTIFACTS=$(BIOS_IMG) $(EFI_PART) $(CONFIG_IMG) $(PERSIST_IMG) $(INITRD_IMG) $(INSTALLER_IMG) $(ROOTFS_IMG) $(SBOM) $(BSP_IMX_PART) fullname-rootfs $(BOOT_PART) | |||
eve: $(INSTALLER) $(EVE_ARTIFACTS) current $(RUNME) $(BUILD_YML) | $(BUILD_DIR) | |||
eve: pkgs $(INSTALLER) $(EVE_ARTIFACTS) current $(RUNME) $(BUILD_YML) | $(BUILD_DIR) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I sometimes do make pkg/pillar rootfs eve.
With this change that will rebuild all of pkg/* from source, which will take an hour or so more.
Why do you need to add pkgs as a dependency here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Otherwise it fails on the pipeline
But:
- It should not take an hour
make -j 8 eve
would help a bit- I guess the way to fix it, is changing
.github/workflows/build.yml
(but let's wait first until eden tests are finished; will do tomorrow)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
By "pipeline" you mean our GH workflows? I thought those explictly do make pkgs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed the commit and now the pipeline fails with: https://github.com/lf-edge/eve/actions/runs/9364843044/job/25779040231?pr=3953
Unable to find image 'lfedge/eve-mkconf:46f3092ae249ee00da2612e368c5e7637922376d' locally
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed the commit and now the pipeline fails with: https://github.com/lf-edge/eve/actions/runs/9364843044/job/25779040231?pr=3953
Unable to find image 'lfedge/eve-mkconf:46f3092ae249ee00da2612e368c5e7637922376d' locally
Is it only pkg/mkconf which needs to be rebuilt? Or are there others?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are more, the next one is:
docker: Error response from daemon: manifest for lfedge/eve-mkrootfs-squash:1c718d751d9f9e57b5e45db7ee07895973c3521f not found: manifest unknown: manifest unknown.
(from https://github.com/lf-edge/eve/actions/runs/9368233114/job/25790219160?pr=3953 )
Unfortunately I cannot reproduce this problem locally (I thought it is this PRUNE=1
but it is a different thing).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Kick of tests
7d5f891
to
9ef73ae
Compare
f22f7ce
to
fa6853a
Compare
:-( |
Signed-off-by: Christoph Ostarek <christoph@zededa.com>
some dependencies seem to miss, so do this to fix it Signed-off-by: Christoph Ostarek <christoph@zededa.com>
fa6853a
to
90fc103
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
No description provided.