Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Driver support wifi on Kontron devices #3970

Merged

Conversation

jsfakian
Copy link
Contributor

  • This change in kconfig concerns the driver support for WIFI on the Kontron devices, which is currently not present. The goal is to enable the Broadcom BCM4356 802.11ac Wireless Network Adapter.
  • We tested it on the Kontron 403 edge device.

Signed-off-by: Ioannis Sfakianakis <jsfakas@gmail.com>
pkg/fw/Dockerfile Outdated Show resolved Hide resolved
KERNEL_COMMIT_arm64_v5.10.186_generic = 594f2361a83f
KERNEL_COMMIT_arm64_v6.1.38_generic = aa4b24ade858
KERNEL_COMMIT_riscv64_v6.1.38_generic = 72192e3cbc74
KERNEL_COMMIT_amd64_v5.10.186_generic = d61682724485
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jsfakian , I guess these changes of kernel commits are unintentional, right? Probably you need to rebase your branch...

Copy link
Contributor Author

@jsfakian jsfakian Jun 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have changed the eve-kernel but still need to update EVE. If it is better to keep only my changes, I will update my PR. The other commits are spelling fixes, so it is fine to remove them.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Understood, I was confuse because you just mention in PR's description about the firmware, so it was not clear whether kernel update was required as well or not. Usually it's better to send kernel updates in a separated PR when they are not related/required by the changes in the PR. Also, it makes easy to solve any conflict while rebasing due to kernel updates, so I would prefer to have the kernel update commit into a separated PR if you don't mind...

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have changed the eve-kernel but still need to update EVE. If it is better to keep only my changes, I will update my PR. The other commits are spelling fixes, so it is fine to remove them.

preferably it must be done using ./tools/update_kernel_commits.py script

@jsfakian jsfakian force-pushed the BUG-CI407-driver-support-wifi-on-kontron branch from 564bae0 to 31cdead Compare June 12, 2024 07:39
@github-actions github-actions bot requested a review from rene June 12, 2024 07:40
…c, arm64-nvidia, arm64-generic, arm64-generic, riscv64-generic]

eve-kernel-amd64-v5.10.186-generic
    d61682724485: Dockerfile.clang: fix spelling errors

eve-kernel-amd64-v6.1.38-generic
    5807270eacf2: Added Broadcom wireless driver
    17e008a1095b: Dockerfile.clang: fix spelling errors

eve-kernel-amd64-v6.1.38-rt
    6e14ff1f47dd: Dockerfile.clang: fix spelling errors

eve-kernel-amd64-v6.1.68-generic
    c825cbffe24f: Dockerfile.clang: fix spelling errors

eve-kernel-arm64-v5.10.104-nvidia
    2473fcc9c1bb: Dockerfile.clang: fix spelling errors

eve-kernel-arm64-v5.10.186-generic
    804663a82829: Dockerfile.clang: fix spelling errors

eve-kernel-arm64-v6.1.38-generic
    39d6c83d31ea: Dockerfile.clang: fix spelling errors

eve-kernel-riscv64-v6.1.38-generic
    a90bcdfa08f8: Dockerfile.clang: fix spelling errors

Signed-off-by: Ioannis Sfakianakis <jsfakas@gmail.com>
@jsfakian jsfakian force-pushed the BUG-CI407-driver-support-wifi-on-kontron branch from 31cdead to fbd6abf Compare June 12, 2024 07:41
Copy link
Contributor

@eriknordmark eriknordmark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eriknordmark eriknordmark merged commit 4a4cad2 into lf-edge:master Jun 13, 2024
28 of 38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants